jonsmock · December 22, 2011 00:57 · Dec 22, 2011 · Dec 22, 2011 · Dec 22, 2011 · Dec 22, 2011
diff --git a/0_the_explanation.txt b/0_the_explanation.txt
@@ -9,9 +9,6 @@ Questions that arise as I code something like this:
  - Which objects deserve presenters?
  - Should I allow HTML in my presenters?
  - Do partials help or do they actually hide complexity that should be
-   eliminated?
- - Do I sometimes take the Law of Demeter too far? (I know an early DAS touched
-   on this)
  - Is this amount of logic ok in a view, if it's tested? (Views are essentially
    methods, right?)
 

diff --git a/0_the_explanation.txt b/0_the_explanation.txt
@@ -1,18 +1,18 @@
-# This example is not my real app, but it's modeled pretty closely to it.
+This example is not my real app, but it's modeled pretty closely to it.
 
-# My mom schedules a couple hundred employees at a local warehouse.  In their
-# system, a worker can earn "points" for being late or missing shifts.  Here
-# we have a sort of summary screen for my mom, who may need to follow up with
-# new employees or discipline employees with concerning levels of points.
+My mom schedules a couple hundred employees at a local warehouse.  In their
+system, a worker can earn "points" for being late or missing shifts.  Here
+we have a sort of summary screen for my mom, who may need to follow up with
+new employees or discipline employees with concerning levels of points.
 
-# Questions that arise as I code something like this:
-# - Which objects deserve presenters?
-# - Should I allow HTML in my presenters?
-# - Do partials help or do they actually hide complexity that should be
-#   eliminated?
-# - Do I sometimes take the Law of Demeter too far? (I know an early DAS touched
-#   on this)
-# - Is this amount of logic ok in a view, if it's tested? (Views are essentially
-#   methods, right?)
+Questions that arise as I code something like this:
+ - Which objects deserve presenters?
+ - Should I allow HTML in my presenters?
+ - Do partials help or do they actually hide complexity that should be
+   eliminated?
+ - Do I sometimes take the Law of Demeter too far? (I know an early DAS touched
+   on this)
+ - Is this amount of logic ok in a view, if it's tested? (Views are essentially
+   methods, right?)
 
-# Of course, those kinds of questions make a 2 hour feature take a day...
+Of course, those kinds of questions make a 2 hour feature take a day...
diff --git a/the_explanation.txt → 0_the_explanation.txt b/the_explanation.txt → 0_the_explanation.txt
diff --git a/the_model.rb → 1_the_model.rb b/the_model.rb → 1_the_model.rb
diff --git a/the_mixin.rb → 2_the_mixin.rb b/the_mixin.rb → 2_the_mixin.rb
diff --git a/the_supporting_class.rb → 3_the_supporting_class.rb b/the_supporting_class.rb → 3_the_supporting_class.rb
diff --git a/the_controller.rb → 4_the_controller.rb b/the_controller.rb → 4_the_controller.rb
diff --git a/the_view.html.erb → 5_the_view.html.erb b/the_view.html.erb → 5_the_view.html.erb
diff --git a/the_controller.rb b/the_controller.rb
@@ -0,0 +1,5 @@
+class RosterController < ApplicationController
+  def index
+    @roster = Roster.new(Employees.morning_shift)
+  end
+end
diff --git a/the_example.rb b/the_example.rb
@@ -1,93 +0,0 @@
-# This example is not my real app, but it's modeled pretty closely to it.
-
-# My mom schedules a couple hundred employees at a local warehouse.  In their
-# system, a worker can earn "points" for being late or missing shifts.  Here
-# we have a sort of summary screen for my mom, who may need to follow up with
-# new employees or discipline employees with concerning levels of points.
-
-# Questions that arise as I code something like this:
-# - Which objects deserve presenters?
-# - Should I allow HTML in my presenters?
-# - Do partials help or do they actually hide complexity that should be
-#   eliminated?
-# - Do I sometimes take the Law of Demeter too far? (I know an early DAS touched
-#   on this)
-# - Is this amount of logic ok in a view, if it's tested? (Views are essentially
-#   methods, right?)
-
-# Of course, those kinds of questions make a 2 hour feature take a day...
-# ...On to the example!
-
-# ---
-
-class Employee < ActiveRecord::Base
-  include EmployeeStatus
-
-  def hired_on; end
-  def received_employee_handbook?; end
-  def scheduled_by; end
-  def last_worked_on; end
-end
-
-module EmployeeStatus
-  def recently_hired?; end  
-  def scheduled?; end
-
-  def points_are_concerning?; end
-  def deliquent_points; end
-end
-
-class Roster
-  attr_accessible :employees
-
-  def initialize(employees)
-    @employees = employees
-  end
-end
-
-class RosterController < ApplicationController
-  def index
-    @roster = Roster.new(Employees.morning_shift)
-  end
-end
-
-#
-# and finally, the nasty, nasty view - barf
-#
-
-<ul>
-<% @roster.employees.each do |employee| %>
-  <li>
-    <h2><%= employee.full_name %></h2>
-
-    <% if employee.recently_hired? %>
-      <p>This employee was hired on <%= employee.hired_on %>
-      <% if employee.scheduled? %>
-        and was scheduled by <%= employee.scheduled_by %>!</p>
-        <%= link_to 'View Shifts', employee_path(employee) %>
-      <% else %>
-        but still needs to be scheduled.</p>
-        <%= link_to 'Schedule now', new_employee_shift_path(employee) %>
-      <% end %>
-
-      <% unless employee.received_employee_handbook? %>
-        <p>Make sure they have a copy of the handbook!</p>
-      <% end %>
-
-    <% elsif employee.points_are_concerning? %>
-      <p>This employee needs disciplinary action.  They currently have
-      <%= pluralize(employee.deliquent_points, 'point') %>.</p>
-      <p>Please consult management before scheduling more shifts.</p>
-
-    <% else %>
-      <% if employee.scheduled? %>
-        This employee is in good standing.  They last worked on <%= employee.last_worked_on %>.
-        <%= link_to 'View Shifts', employee_path(employee) %>
-      <% else %>
-        <p>This employee has never been scheduled.</p>
-        <%= link_to 'Schedule now', new_employee_shift_path(employee) %>
-      <% end %>
-    <% end %>
-  </li>
-<% end %>
-</ul>

diff --git a/the_explanation.txt b/the_explanation.txt
@@ -0,0 +1,18 @@
+# This example is not my real app, but it's modeled pretty closely to it.
+
+# My mom schedules a couple hundred employees at a local warehouse.  In their
+# system, a worker can earn "points" for being late or missing shifts.  Here
+# we have a sort of summary screen for my mom, who may need to follow up with
+# new employees or discipline employees with concerning levels of points.
+
+# Questions that arise as I code something like this:
+# - Which objects deserve presenters?
+# - Should I allow HTML in my presenters?
+# - Do partials help or do they actually hide complexity that should be
+#   eliminated?
+# - Do I sometimes take the Law of Demeter too far? (I know an early DAS touched
+#   on this)
+# - Is this amount of logic ok in a view, if it's tested? (Views are essentially
+#   methods, right?)
+
+# Of course, those kinds of questions make a 2 hour feature take a day...
diff --git a/the_mixin.rb b/the_mixin.rb
@@ -0,0 +1,7 @@
+module EmployeeStatus
+  def recently_hired?; end  
+  def scheduled?; end
+
+  def points_are_concerning?; end
+  def deliquent_points; end
+end
diff --git a/the_model.rb b/the_model.rb
@@ -0,0 +1,8 @@
+class Employee < ActiveRecord::Base
+  include EmployeeStatus
+
+  def hired_on; end
+  def received_employee_handbook?; end
+  def scheduled_by; end
+  def last_worked_on; end
+end
diff --git a/the_supporting_class.rb b/the_supporting_class.rb
@@ -0,0 +1,7 @@
+class Roster
+  attr_accessible :employees
+
+  def initialize(employees)
+    @employees = employees
+  end
+end
diff --git a/the_view.html.erb b/the_view.html.erb
@@ -0,0 +1,36 @@
+<ul>
+<% @roster.employees.each do |employee| %>
+  <li>
+    <h2><%= employee.full_name %></h2>
+
+    <% if employee.recently_hired? %>
+      <p>This employee was hired on <%= employee.hired_on %>
+      <% if employee.scheduled? %>
+        and was scheduled by <%= employee.scheduled_by %>!</p>
+        <%= link_to 'View Shifts', employee_path(employee) %>
+      <% else %>
+        but still needs to be scheduled.</p>
+        <%= link_to 'Schedule now', new_employee_shift_path(employee) %>
+      <% end %>
+
+      <% unless employee.received_employee_handbook? %>
+        <p>Make sure they have a copy of the handbook!</p>
+      <% end %>
+
+    <% elsif employee.points_are_concerning? %>
+      <p>This employee needs disciplinary action.  They currently have
+      <%= pluralize(employee.deliquent_points, 'point') %>.</p>
+      <p>Please consult management before scheduling more shifts.</p>
+
+    <% else %>
+      <% if employee.scheduled? %>
+        This employee is in good standing.  They last worked on <%= employee.last_worked_on %>.
+        <%= link_to 'View Shifts', employee_path(employee) %>
+      <% else %>
+        <p>This employee has never been scheduled.</p>
+        <%= link_to 'Schedule now', new_employee_shift_path(employee) %>
+      <% end %>
+    <% end %>
+  </li>
+<% end %>
+</ul>
diff --git a/the_example.rb b/the_example.rb
@@ -0,0 +1,93 @@
+# This example is not my real app, but it's modeled pretty closely to it.
+
+# My mom schedules a couple hundred employees at a local warehouse.  In their
+# system, a worker can earn "points" for being late or missing shifts.  Here
+# we have a sort of summary screen for my mom, who may need to follow up with
+# new employees or discipline employees with concerning levels of points.
+
+# Questions that arise as I code something like this:
+# - Which objects deserve presenters?
+# - Should I allow HTML in my presenters?
+# - Do partials help or do they actually hide complexity that should be
+#   eliminated?
+# - Do I sometimes take the Law of Demeter too far? (I know an early DAS touched
+#   on this)
+# - Is this amount of logic ok in a view, if it's tested? (Views are essentially
+#   methods, right?)
+
+# Of course, those kinds of questions make a 2 hour feature take a day...
+# ...On to the example!
+
+# ---
+
+class Employee < ActiveRecord::Base
+  include EmployeeStatus
+
+  def hired_on; end
+  def received_employee_handbook?; end
+  def scheduled_by; end
+  def last_worked_on; end
+end
+
+module EmployeeStatus
+  def recently_hired?; end  
+  def scheduled?; end
+
+  def points_are_concerning?; end
+  def deliquent_points; end
+end
+
+class Roster
+  attr_accessible :employees
+
+  def initialize(employees)
+    @employees = employees
+  end
+end
+
+class RosterController < ApplicationController
+  def index
+    @roster = Roster.new(Employees.morning_shift)
+  end
+end
+
+#
+# and finally, the nasty, nasty view - barf
+#
+
+<ul>
+<% @roster.employees.each do |employee| %>
+  <li>
+    <h2><%= employee.full_name %></h2>
+
+    <% if employee.recently_hired? %>
+      <p>This employee was hired on <%= employee.hired_on %>
+      <% if employee.scheduled? %>
+        and was scheduled by <%= employee.scheduled_by %>!</p>
+        <%= link_to 'View Shifts', employee_path(employee) %>
+      <% else %>
+        but still needs to be scheduled.</p>
+        <%= link_to 'Schedule now', new_employee_shift_path(employee) %>
+      <% end %>
+
+      <% unless employee.received_employee_handbook? %>
+        <p>Make sure they have a copy of the handbook!</p>
+      <% end %>
+
+    <% elsif employee.points_are_concerning? %>
+      <p>This employee needs disciplinary action.  They currently have
+      <%= pluralize(employee.deliquent_points, 'point') %>.</p>
+      <p>Please consult management before scheduling more shifts.</p>
+
+    <% else %>
+      <% if employee.scheduled? %>
+        This employee is in good standing.  They last worked on <%= employee.last_worked_on %>.
+        <%= link_to 'View Shifts', employee_path(employee) %>
+      <% else %>
+        <p>This employee has never been scheduled.</p>
+        <%= link_to 'Schedule now', new_employee_shift_path(employee) %>
+      <% end %>
+    <% end %>
+  </li>
+<% end %>
+</ul>