Skip to content

Instantly share code, notes, and snippets.

@thedeveloperr

thedeveloperr/gsoc_2020_zulip_workproduct.md

Last active August 31, 2020 16:15
Show Gist options
  • Save thedeveloperr/0e75649034e103efe7549d96ca09f9e3 to your computer and use it in GitHub Desktop.
Save thedeveloperr/0e75649034e103efe7549d96ca09f9e3 to your computer and use it in GitHub Desktop.
Download ZIP

Revisions

  1. thedeveloperr revised this gist Aug 31, 2020. 1 changed file with 8 additions and 2 deletions.
    10 changes: 8 additions & 2 deletions gsoc_2020_zulip_workproduct.md
    View file
    Original file line number Diff line number Diff line change
    @@ -14,23 +14,29 @@ Work have been focused upon:
    - Adding script to detect any unnecessary console output while running tests in CI
    - Adding keyboard support for left and right sidebar popover menu.
    - Making has:link, has:attachment, has:image work on client side.
    - Fixing full text search bug.

    I want to thank my GSoC's mentor **[Shubham Padia](https://github.com/shubham-padia)** for guidance.
    I also want to thank Zulip's **[Tim Abbott](https://github.com/timabbott)**, **[Steve Howell](https://github.com/showell)**, **[Anders Kaseorg](https://github.com/andersk)**, **[Rohitt Vashishtha](https://github.com/aero31aero)**, and many other community members for their support and help during my GSoC journey. I am grateful.

    ## Work summary

    #### Issue: [Can only find URLs when entering them completely. #9165](https://github.com/zulip/zulip/issues/9165) Right now user have to search messages by typing full urls and the postgres don't index parts of urls. Aim of the work is to allow user to search by typing parts of url instead of full url.
    PRs that solves it:
    * [[WIP] search: Allow searching of messages with link by typing parts of url.](https://github.com/zulip/zulip/pull/16243) It's a WIP work. Essentially it does is that extract urls from rendered html of messages and tokenise them by replacing characters: `.,-,_,/` in the url with space and then index them in postgres for full text search. This will allow the user to search the rendered content by typing just parts of url instead of typing full urls

    #### Issue: [Verify `test-backend` doesn't produce extra output spam in CI #1587](https://github.com/zulip/zulip/issues/1587)
    PRs that solves it:
    * [Add spam detection in test-backend output](https://github.com/zulip/zulip/pull/16165): Script to detect unexpected output and tell the test which produced it. A major challenge was that tests were running in parallel. Detection of unexpected console output was not difficult but pin pointing the test that produced it accurate was difficult while tests were running in parralel. With effort finally I was able to solve the problem. (Merged)
    * Cleaning up logs, unnecessary console outputs. Most of commits have been merged or were modified and then merged: https://github.com/zulip/zulip/pull/15769, https://github.com/zulip/zulip/pull/15862, https://github.com/zulip/zulip/pull/15867, https://github.com/zulip/zulip/pull/15881, https://github.com/zulip/zulip/pull/15927, https://github.com/zulip/zulip/pull/15934, https://github.com/zulip/zulip/pull/15942

    #### Issue: [has:image broken? #16118](https://github.com/zulip/zulip/issues/16118)
    PR that solves it:
    * [filters: Fix has:image and avoid future issues for other has filters. #16126](https://github.com/zulip/zulip/pull/16126) Merged as commit [4167517](https://github.com/zulip/zulip/commit/4167517a6fc61eb1e1df9cc35068eabb868c7cbe) This fixed a bug that was introduced in my previous work on has: fileters. The issue was when the message content had a missing outer html tag the search broke. Fixed the issue in such a way, no matter how much html changes in future the search logic won't break.
    * [filters: Fix has:image and avoid future issues for other has filters. #16126](https://github.com/zulip/zulip/pull/16126) Merged as commit [4167517](https://github.com/zulip/zulip/commit/4167517a6fc61eb1e1df9cc35068eabb868c7cbe) This fixed a bug that was introduced in my previous work on has: filters. The issue was when the message content had a missing outer html tag the search broke. Fixed the issue in such a way, no matter how much html changes in future the search logic won't break.

    #### Issue: [popovers: Improve keyboard navigation #15448](https://github.com/zulip/zulip/issues/15448)
    PRs that solves it:
    * [popovers: Improve keyboard navigation #15722](https://github.com/zulip/zulip/pull/15722) This PR adds ability to move the arrow buttongs to navigate the items of of the left and right sidebar's popover menus when it is open. This PR also had a commit to open stream popover menu using 'i' hotkey but the commit was removed by a force push as more planning was needed for right way to open the stream popover with keyboard.
    * [popovers: Improve keyboard navigation #15722](https://github.com/zulip/zulip/pull/15722) This PR adds ability to move the arrow buttons to navigate the items of of the left and right sidebar's popover menus when it is open. This PR also had a commit to open stream popover menu using 'i' hotkey but the commit was removed by a force push as more planning was needed for right way to open the stream popover with keyboard.

    #### Issue: [Add web-app filters for has:link, has:attachment, and has:image. #6186](https://github.com/zulip/zulip/issues/6186)
    PRs that solves it:
  2. thedeveloperr revised this gist Aug 29, 2020. 1 changed file with 10 additions and 16 deletions.
    26 changes: 10 additions & 16 deletions gsoc_2020_zulip_workproduct.md
    View file
    Original file line number Diff line number Diff line change
    @@ -19,34 +19,28 @@ I want to thank my GSoC's mentor **[Shubham Padia](https://github.com/shubham-pa
    I also want to thank Zulip's **[Tim Abbott](https://github.com/timabbott)**, **[Steve Howell](https://github.com/showell)**, **[Anders Kaseorg](https://github.com/andersk)**, **[Rohitt Vashishtha](https://github.com/aero31aero)**, and many other community members for their support and help during my GSoC journey. I am grateful.

    ## Work summary
    - Issue: [Verify `test-backend` doesn't produce extra output spam in CI #1587](https://github.com/zulip/zulip/issues/1587)

    #### Issue: [Verify `test-backend` doesn't produce extra output spam in CI #1587](https://github.com/zulip/zulip/issues/1587)
    PRs that solves it:
    * [Add spam detection in test-backend output](https://github.com/zulip/zulip/pull/16165): Script to detect unexpected output and tell the test which produced it. A major challenge was that tests were running in parallel. Detection of unexpected console output was not difficult but pin pointing the test that produced it accurate was difficult while tests were running in parralel. With effort finally I was able to solve the problem. (Merged)
    * Cleaning up logs, unnecessary console outputs. Most of commits have been merged or were modified and then merged: https://github.com/zulip/zulip/pull/15769, https://github.com/zulip/zulip/pull/15862, https://github.com/zulip/zulip/pull/15867, https://github.com/zulip/zulip/pull/15881, https://github.com/zulip/zulip/pull/15927, https://github.com/zulip/zulip/pull/15934, https://github.com/zulip/zulip/pull/15942

    - Issue: [has:image broken? #16118](https://github.com/zulip/zulip/issues/16118)

    #### Issue: [has:image broken? #16118](https://github.com/zulip/zulip/issues/16118)
    PR that solves it:
    * [filters: Fix has:image and avoid future issues for other has filters. #16126](https://github.com/zulip/zulip/pull/16126) Merged as commit [4167517](https://github.com/zulip/zulip/commit/4167517a6fc61eb1e1df9cc35068eabb868c7cbe) This fixed a bug that was introduced in my previous work on has: fileters. The issue was when the message content had a missing outer html tag the search broke. Fixed the issue in such a way, no matter how much html changes in future the search logic won't break.

    - Issue: [popovers: Improve keyboard navigation #15448](https://github.com/zulip/zulip/issues/15448)

    #### Issue: [popovers: Improve keyboard navigation #15448](https://github.com/zulip/zulip/issues/15448)
    PRs that solves it:
    * [popovers: Improve keyboard navigation #15722](https://github.com/zulip/zulip/pull/15722) This PR adds ability to move the arrow buttongs to navigate the items of of the left and right sidebar's popover menus when it is open. This PR also had a commit to open stream popover menu using 'i' hotkey but the commit was removed by a force push as more planning was needed for right way to open the stream popover with keyboard.

    - Issue: [Add web-app filters for has:link, has:attachment, and has:image. #6186](https://github.com/zulip/zulip/issues/6186)

    #### Issue: [Add web-app filters for has:link, has:attachment, and has:image. #6186](https://github.com/zulip/zulip/issues/6186)
    PRs that solves it:
    * Initially started with: https://github.com/zulip/zulip/pull/15363 (Not merged) but it was closed in favor of - [filter: Implement has: filters on client side. #15492](https://github.com/zulip/zulip/pull/15492) (Commits from PR merged) The goal was basically to bring the has: search filter to client side on webapp for better and quick serching of messages already in browser's local memory.

    - Issue: Refactor and split the tests test_messages.py into seperate files.

    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15661, https://github.com/zulip/zulip/pull/15716, https://github.com/zulip/zulip/pull/15711 The main work here was thinking best destination for each test and making sure imports are proper.

    - Issue: Remove word bugdown and rename it with word markdown.
    #### Issue: Refactor and split the tests test_messages.py into seperate files.
    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15661, https://github.com/zulip/zulip/pull/15716, https://github.com/zulip/zulip/pull/15711 The main work here was thinking best destination for each test and making sure imports are proper.

    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15569, https://github.com/zulip/zulip/pull/15606 Zulip's markdown flavor for historical reasons was called bugdown which was a confusing term. So a refactor was done to change the word bugdown to markdown from whole code. The challenge like any other refactor was to do this without breaking anything.
    #### Issue: Remove word bugdown and rename it with word markdown.
    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15569, https://github.com/zulip/zulip/pull/15606 Zulip's markdown flavor for historical reasons was called bugdown which was a confusing term. So a refactor was done to change the word bugdown to markdown from whole code. The challenge like any other refactor was to do this without breaking anything.

  3. thedeveloperr revised this gist Aug 29, 2020. 1 changed file with 4 additions and 4 deletions.
    8 changes: 4 additions & 4 deletions gsoc_2020_zulip_workproduct.md
    View file
    Original file line number Diff line number Diff line change
    @@ -42,11 +42,11 @@ PRs that solves it:

    - Issue: Refactor and split the tests test_messages.py into seperate files.

    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15661, https://github.com/zulip/zulip/pull/15716, https://github.com/zulip/zulip/pull/15711 The main work here was thinking best destination for each test and making sure imports are proper.
    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15661, https://github.com/zulip/zulip/pull/15716, https://github.com/zulip/zulip/pull/15711 The main work here was thinking best destination for each test and making sure imports are proper.

    - Issue: Remove word bugdown and rename it with word markdown.

    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15569, https://github.com/zulip/zulip/pull/15606 Zulip's markdown flavor for historical reasons was called bugdown which was a confusing term. So a refactor was done to change the word bugdown to markdown from whole code. The challenge like any other refactor was to do this without breaking anything.
    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15569, https://github.com/zulip/zulip/pull/15606 Zulip's markdown flavor for historical reasons was called bugdown which was a confusing term. So a refactor was done to change the word bugdown to markdown from whole code. The challenge like any other refactor was to do this without breaking anything.

  4. thedeveloperr revised this gist Aug 29, 2020. 1 changed file with 6 additions and 6 deletions.
    12 changes: 6 additions & 6 deletions gsoc_2020_zulip_workproduct.md
    View file
    Original file line number Diff line number Diff line change
    @@ -19,33 +19,33 @@ I want to thank my GSoC's mentor **[Shubham Padia](https://github.com/shubham-pa
    I also want to thank Zulip's **[Tim Abbott](https://github.com/timabbott)**, **[Steve Howell](https://github.com/showell)**, **[Anders Kaseorg](https://github.com/andersk)**, **[Rohitt Vashishtha](https://github.com/aero31aero)**, and many other community members for their support and help during my GSoC journey. I am grateful.

    ## Work summary
    Issue: [Verify `test-backend` doesn't produce extra output spam in CI #1587](https://github.com/zulip/zulip/issues/1587)
    - Issue: [Verify `test-backend` doesn't produce extra output spam in CI #1587](https://github.com/zulip/zulip/issues/1587)

    PRs that solves it:
    * [Add spam detection in test-backend output](https://github.com/zulip/zulip/pull/16165): Script to detect unexpected output and tell the test which produced it. A major challenge was that tests were running in parallel. Detection of unexpected console output was not difficult but pin pointing the test that produced it accurate was difficult while tests were running in parralel. With effort finally I was able to solve the problem. (Merged)
    * Cleaning up logs, unnecessary console outputs. Most of commits have been merged or were modified and then merged: https://github.com/zulip/zulip/pull/15769, https://github.com/zulip/zulip/pull/15862, https://github.com/zulip/zulip/pull/15867, https://github.com/zulip/zulip/pull/15881, https://github.com/zulip/zulip/pull/15927, https://github.com/zulip/zulip/pull/15934, https://github.com/zulip/zulip/pull/15942

    Issue: [has:image broken? #16118](https://github.com/zulip/zulip/issues/16118)
    - Issue: [has:image broken? #16118](https://github.com/zulip/zulip/issues/16118)

    PR that solves it:
    * [filters: Fix has:image and avoid future issues for other has filters. #16126](https://github.com/zulip/zulip/pull/16126) Merged as commit [4167517](https://github.com/zulip/zulip/commit/4167517a6fc61eb1e1df9cc35068eabb868c7cbe) This fixed a bug that was introduced in my previous work on has: fileters. The issue was when the message content had a missing outer html tag the search broke. Fixed the issue in such a way, no matter how much html changes in future the search logic won't break.

    Issue: [popovers: Improve keyboard navigation #15448](https://github.com/zulip/zulip/issues/15448)
    - Issue: [popovers: Improve keyboard navigation #15448](https://github.com/zulip/zulip/issues/15448)

    PRs that solves it:
    * [popovers: Improve keyboard navigation #15722](https://github.com/zulip/zulip/pull/15722) This PR adds ability to move the arrow buttongs to navigate the items of of the left and right sidebar's popover menus when it is open. This PR also had a commit to open stream popover menu using 'i' hotkey but the commit was removed by a force push as more planning was needed for right way to open the stream popover with keyboard.

    Issue: [Add web-app filters for has:link, has:attachment, and has:image. #6186](https://github.com/zulip/zulip/issues/6186)
    - Issue: [Add web-app filters for has:link, has:attachment, and has:image. #6186](https://github.com/zulip/zulip/issues/6186)

    PRs that solves it:
    * Initially started with: https://github.com/zulip/zulip/pull/15363 (Not merged) but it was closed in favor of - [filter: Implement has: filters on client side. #15492](https://github.com/zulip/zulip/pull/15492) (Commits from PR merged) The goal was basically to bring the has: search filter to client side on webapp for better and quick serching of messages already in browser's local memory.

    Issue: Refactor and split the tests test_messages.py into seperate files.
    - Issue: Refactor and split the tests test_messages.py into seperate files.

    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15661, https://github.com/zulip/zulip/pull/15716, https://github.com/zulip/zulip/pull/15711 The main work here was thinking best destination for each test and making sure imports are proper.

    Issue: Remove word bugdown and rename it with word markdown.
    - Issue: Remove word bugdown and rename it with word markdown.

    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15569, https://github.com/zulip/zulip/pull/15606 Zulip's markdown flavor for historical reasons was called bugdown which was a confusing term. So a refactor was done to change the word bugdown to markdown from whole code. The challenge like any other refactor was to do this without breaking anything.
  5. thedeveloperr revised this gist Aug 29, 2020. 1 changed file with 7 additions and 0 deletions.
    7 changes: 7 additions & 0 deletions gsoc_2020_zulip_workproduct.md
    View file
    Original file line number Diff line number Diff line change
    @@ -20,26 +20,33 @@ I also want to thank Zulip's **[Tim Abbott](https://github.com/timabbott)**, **

    ## Work summary
    Issue: [Verify `test-backend` doesn't produce extra output spam in CI #1587](https://github.com/zulip/zulip/issues/1587)

    PRs that solves it:
    * [Add spam detection in test-backend output](https://github.com/zulip/zulip/pull/16165): Script to detect unexpected output and tell the test which produced it. A major challenge was that tests were running in parallel. Detection of unexpected console output was not difficult but pin pointing the test that produced it accurate was difficult while tests were running in parralel. With effort finally I was able to solve the problem. (Merged)
    * Cleaning up logs, unnecessary console outputs. Most of commits have been merged or were modified and then merged: https://github.com/zulip/zulip/pull/15769, https://github.com/zulip/zulip/pull/15862, https://github.com/zulip/zulip/pull/15867, https://github.com/zulip/zulip/pull/15881, https://github.com/zulip/zulip/pull/15927, https://github.com/zulip/zulip/pull/15934, https://github.com/zulip/zulip/pull/15942

    Issue: [has:image broken? #16118](https://github.com/zulip/zulip/issues/16118)

    PR that solves it:
    * [filters: Fix has:image and avoid future issues for other has filters. #16126](https://github.com/zulip/zulip/pull/16126) Merged as commit [4167517](https://github.com/zulip/zulip/commit/4167517a6fc61eb1e1df9cc35068eabb868c7cbe) This fixed a bug that was introduced in my previous work on has: fileters. The issue was when the message content had a missing outer html tag the search broke. Fixed the issue in such a way, no matter how much html changes in future the search logic won't break.

    Issue: [popovers: Improve keyboard navigation #15448](https://github.com/zulip/zulip/issues/15448)

    PRs that solves it:
    * [popovers: Improve keyboard navigation #15722](https://github.com/zulip/zulip/pull/15722) This PR adds ability to move the arrow buttongs to navigate the items of of the left and right sidebar's popover menus when it is open. This PR also had a commit to open stream popover menu using 'i' hotkey but the commit was removed by a force push as more planning was needed for right way to open the stream popover with keyboard.

    Issue: [Add web-app filters for has:link, has:attachment, and has:image. #6186](https://github.com/zulip/zulip/issues/6186)

    PRs that solves it:
    * Initially started with: https://github.com/zulip/zulip/pull/15363 (Not merged) but it was closed in favor of - [filter: Implement has: filters on client side. #15492](https://github.com/zulip/zulip/pull/15492) (Commits from PR merged) The goal was basically to bring the has: search filter to client side on webapp for better and quick serching of messages already in browser's local memory.

    Issue: Refactor and split the tests test_messages.py into seperate files.

    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15661, https://github.com/zulip/zulip/pull/15716, https://github.com/zulip/zulip/pull/15711 The main work here was thinking best destination for each test and making sure imports are proper.

    Issue: Remove word bugdown and rename it with word markdown.

    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15569, https://github.com/zulip/zulip/pull/15606 Zulip's markdown flavor for historical reasons was called bugdown which was a confusing term. So a refactor was done to change the word bugdown to markdown from whole code. The challenge like any other refactor was to do this without breaking anything.

  6. thedeveloperr revised this gist Aug 29, 2020. 1 changed file with 1 addition and 1 deletion.
    2 changes: 1 addition & 1 deletion gsoc_2020_zulip_workproduct.md
    View file
    Original file line number Diff line number Diff line change
    @@ -15,7 +15,7 @@ Work have been focused upon:
    - Adding keyboard support for left and right sidebar popover menu.
    - Making has:link, has:attachment, has:image work on client side.

    I want to thank my GSoC's mentor **[Shubham Padia](https://github.com/shubham-padia)** for guidance
    I want to thank my GSoC's mentor **[Shubham Padia](https://github.com/shubham-padia)** for guidance.
    I also want to thank Zulip's **[Tim Abbott](https://github.com/timabbott)**, **[Steve Howell](https://github.com/showell)**, **[Anders Kaseorg](https://github.com/andersk)**, **[Rohitt Vashishtha](https://github.com/aero31aero)**, and many other community members for their support and help during my GSoC journey. I am grateful.

    ## Work summary
  7. thedeveloperr revised this gist Aug 29, 2020. 1 changed file with 1 addition and 1 deletion.
    2 changes: 1 addition & 1 deletion gsoc_2020_zulip_workproduct.md
    View file
    Original file line number Diff line number Diff line change
    @@ -1,5 +1,5 @@
    # Work Product Document for Zulip open source project as GSoC 2020 student developer.
    **Mohit Gupta** | [Github](https://github.com/thedeveloperr) | [Linkedin](https://www.linkedin.com/in/mohit-gupta-developer/)
    **Mohit Gupta** | [Github](https://github.com/thedeveloperr)

    **Areas worked in:** Tests, Search, Refactor, Keyboard support

  8. thedeveloperr revised this gist Aug 29, 2020. 1 changed file with 9 additions and 0 deletions.
    9 changes: 9 additions & 0 deletions gsoc_2020_zulip_workproduct.md
    View file
    Original file line number Diff line number Diff line change
    @@ -28,9 +28,18 @@ Issue: [has:image broken? #16118](https://github.com/zulip/zulip/issues/16118)
    PR that solves it:
    * [filters: Fix has:image and avoid future issues for other has filters. #16126](https://github.com/zulip/zulip/pull/16126) Merged as commit [4167517](https://github.com/zulip/zulip/commit/4167517a6fc61eb1e1df9cc35068eabb868c7cbe) This fixed a bug that was introduced in my previous work on has: fileters. The issue was when the message content had a missing outer html tag the search broke. Fixed the issue in such a way, no matter how much html changes in future the search logic won't break.

    Issue: [popovers: Improve keyboard navigation #15448](https://github.com/zulip/zulip/issues/15448)
    PRs that solves it:
    * [popovers: Improve keyboard navigation #15722](https://github.com/zulip/zulip/pull/15722) This PR adds ability to move the arrow buttongs to navigate the items of of the left and right sidebar's popover menus when it is open. This PR also had a commit to open stream popover menu using 'i' hotkey but the commit was removed by a force push as more planning was needed for right way to open the stream popover with keyboard.

    Issue: [Add web-app filters for has:link, has:attachment, and has:image. #6186](https://github.com/zulip/zulip/issues/6186)
    PRs that solves it:
    * Initially started with: https://github.com/zulip/zulip/pull/15363 (Not merged) but it was closed in favor of - [filter: Implement has: filters on client side. #15492](https://github.com/zulip/zulip/pull/15492) (Commits from PR merged) The goal was basically to bring the has: search filter to client side on webapp for better and quick serching of messages already in browser's local memory.

    Issue: Refactor and split the tests test_messages.py into seperate files.
    PRs that do the refactors:
    * https://github.com/zulip/zulip/pull/15661, https://github.com/zulip/zulip/pull/15716, https://github.com/zulip/zulip/pull/15711 The main work here was thinking best destination for each test and making sure imports are proper.

    Issue: Remove word bugdown and rename it with word markdown.
    * https://github.com/zulip/zulip/pull/15569, https://github.com/zulip/zulip/pull/15606 Zulip's markdown flavor for historical reasons was called bugdown which was a confusing term. So a refactor was done to change the word bugdown to markdown from whole code. The challenge like any other refactor was to do this without breaking anything.

  9. thedeveloperr revised this gist Aug 29, 2020. 1 changed file with 8 additions and 2 deletions.
    10 changes: 8 additions & 2 deletions gsoc_2020_zulip_workproduct.md
    View file
    Original file line number Diff line number Diff line change
    @@ -22,9 +22,15 @@ I also want to thank Zulip's **[Tim Abbott](https://github.com/timabbott)**, **
    Issue: [Verify `test-backend` doesn't produce extra output spam in CI #1587](https://github.com/zulip/zulip/issues/1587)
    PRs that solves it:
    * [Add spam detection in test-backend output](https://github.com/zulip/zulip/pull/16165): Script to detect unexpected output and tell the test which produced it. A major challenge was that tests were running in parallel. Detection of unexpected console output was not difficult but pin pointing the test that produced it accurate was difficult while tests were running in parralel. With effort finally I was able to solve the problem. (Merged)
    * Cleaning up logs, unnecessary console outputs: https://github.com/zulip/zulip/pull/15769, https://github.com/zulip/zulip/pull/15862, https://github.com/zulip/zulip/pull/15867, https://github.com/zulip/zulip/pull/15881, https://github.com/zulip/zulip/pull/15927, https://github.com/zulip/zulip/pull/15934, https://github.com/zulip/zulip/pull/15942
    * Cleaning up logs, unnecessary console outputs. Most of commits have been merged or were modified and then merged: https://github.com/zulip/zulip/pull/15769, https://github.com/zulip/zulip/pull/15862, https://github.com/zulip/zulip/pull/15867, https://github.com/zulip/zulip/pull/15881, https://github.com/zulip/zulip/pull/15927, https://github.com/zulip/zulip/pull/15934, https://github.com/zulip/zulip/pull/15942

    Issue: [has:image broken? #16118](https://github.com/zulip/zulip/issues/16118)
    PR that solves it:
    * [filters: Fix has:image and avoid future issues for other has filters. #16126](https://github.com/zulip/zulip/pull/16126) Merged as commit [4167517](https://github.com/zulip/zulip/commit/4167517a6fc61eb1e1df9cc35068eabb868c7cbe) This fixed a bug that was introduced in my previous work on has: fileters. The issue was when the message content had a missing outer html tag the search broke. Fixed the issue in such a way, no matter how much html changes in future the search logic won't break.

    Issue: [Add web-app filters for has:link, has:attachment, and has:image. #6186](https://github.com/zulip/zulip/issues/6186)
    PRs that solves it:
    * Initially started with: https://github.com/zulip/zulip/pull/15363 (Not merged) but it was closed in favor of - [filter: Implement has: filters on client side. #15492](https://github.com/zulip/zulip/pull/15492) (Commits from PR merged)
    * Initially started with: https://github.com/zulip/zulip/pull/15363 (Not merged) but it was closed in favor of - [filter: Implement has: filters on client side. #15492](https://github.com/zulip/zulip/pull/15492) (Commits from PR merged) The goal was basically to bring the has: search filter to client side on webapp for better and quick serching of messages already in browser's local memory.



  10. thedeveloperr created this gist Aug 28, 2020.
    30 changes: 30 additions & 0 deletions gsoc_2020_zulip_workproduct.md
    View file
    Original file line number Diff line number Diff line change
    @@ -0,0 +1,30 @@
    # Work Product Document for Zulip open source project as GSoC 2020 student developer.
    **Mohit Gupta** | [Github](https://github.com/thedeveloperr) | [Linkedin](https://www.linkedin.com/in/mohit-gupta-developer/)

    **Areas worked in:** Tests, Search, Refactor, Keyboard support

    ## Introduction
    This gist contains work done during Google Summer of Code 2020 with Zulip open source project. Most of my work is fullstack. I Worked both on:
    * Zulip's main frontend webapp which is in Javascript
    * Zulip backend server which uses Python

    Work have been focused upon:
    - Refactor of code related to tests
    - Cleaning up logging output and verifying it without printing in test output making CI test output clean
    - Adding script to detect any unnecessary console output while running tests in CI
    - Adding keyboard support for left and right sidebar popover menu.
    - Making has:link, has:attachment, has:image work on client side.

    I want to thank my GSoC's mentor **[Shubham Padia](https://github.com/shubham-padia)** for guidance
    I also want to thank Zulip's **[Tim Abbott](https://github.com/timabbott)**, **[Steve Howell](https://github.com/showell)**, **[Anders Kaseorg](https://github.com/andersk)**, **[Rohitt Vashishtha](https://github.com/aero31aero)**, and many other community members for their support and help during my GSoC journey. I am grateful.

    ## Work summary
    Issue: [Verify `test-backend` doesn't produce extra output spam in CI #1587](https://github.com/zulip/zulip/issues/1587)
    PRs that solves it:
    * [Add spam detection in test-backend output](https://github.com/zulip/zulip/pull/16165): Script to detect unexpected output and tell the test which produced it. A major challenge was that tests were running in parallel. Detection of unexpected console output was not difficult but pin pointing the test that produced it accurate was difficult while tests were running in parralel. With effort finally I was able to solve the problem. (Merged)
    * Cleaning up logs, unnecessary console outputs: https://github.com/zulip/zulip/pull/15769, https://github.com/zulip/zulip/pull/15862, https://github.com/zulip/zulip/pull/15867, https://github.com/zulip/zulip/pull/15881, https://github.com/zulip/zulip/pull/15927, https://github.com/zulip/zulip/pull/15934, https://github.com/zulip/zulip/pull/15942

    Issue: [Add web-app filters for has:link, has:attachment, and has:image. #6186](https://github.com/zulip/zulip/issues/6186)
    PRs that solves it:
    * Initially started with: https://github.com/zulip/zulip/pull/15363 (Not merged) but it was closed in favor of - [filter: Implement has: filters on client side. #15492](https://github.com/zulip/zulip/pull/15492) (Commits from PR merged)