JoshuaTheMiller · January 11, 2021 22:21 · Jan 11, 2021 · Jan 11, 2021 · Jan 11, 2021 · Jan 11, 2021
diff --git a/groundwork.js b/groundwork.js
@@ -14,5 +14,9 @@ class weatherForecasterService{
   }
 }
 
+function useWeatherForecaster(weatherForecaster) {
+  console.log(weatherForecaster.generateWeatherForecast("Minnesota"))
+}
+
 const weatherForecaster = new weatherForecasterService();
-console.log(weatherForecaster.generateWeatherForecast("Minnesota"))
+useWeatherForecaster(weatherForecaster);
diff --git a/_README.md → _PoorMansFeatureToggle.md b/_README.md → _PoorMansFeatureToggle.md
diff --git a/_README.md b/_README.md
@@ -1 +1 @@
-This Gist and the associated were created to support an article on Feature Flags (to be linked)
+This Gist and the associated files were created to support an article on Feature Flags (to be linked)
diff --git a/_README.md b/_README.md
@@ -0,0 +1 @@
+This Gist and the associated were created to support an article on Feature Flags (to be linked)
diff --git a/groundwork.js b/groundwork.js
@@ -6,13 +6,13 @@ function appendAmountOfRain(forecast) {
   return `${forecast} with 3cm of rain`;
 }
 
-class weatherForcasterService{
+class weatherForecasterService{
   generateWeatherForecast(location) {
     const forecast = buildForecast(location);
     // We have been asked to insert appendAmountOfRain(...) here
     return forecast;
   }
 }
 
-const weatherForecaster = new weatherForcasterService();
+const weatherForecaster = new weatherForecasterService();
 console.log(weatherForecaster.generateWeatherForecast("Minnesota"))
diff --git a/v1.js b/v1.js
@@ -1,4 +1,4 @@
-const weatherForcasterService = {
+const weatherForecasterService = {
   generateWeatherForecast: function (location) {
     let forecast = buildForecast(location);
     if(process.env.CURRENT_ENVIRONMENT === "nonprod") {

diff --git a/v2.js b/v2.js
@@ -1,5 +1,5 @@
 const features = getFeatureFlagServiceFromSomewhere()
-class weatherForcasterService{
+class weatherForecasterService{
   generateWeatherForecast(location) {
     let forecast = buildForecast(location);
     if(features.isEnabled("amount-of-rain")) {

diff --git a/v3.js b/v3.js
@@ -1,5 +1,5 @@
 const featureDecisions = getFeatureDecisionServiceFromSomewhere()
-class weatherForcasterService{
+class weatherForecasterService{
   generateWeatherForecast(location) {
     let forecast = buildForecast(location);
     if(featureDecisions.appendAmountOfRainToForecast()) {

diff --git a/v4.js b/v4.js
@@ -1,4 +1,4 @@
-class weatherForcasterService{  
+class weatherForecasterService{  
   constructor(options) {
     this.options = options ?? {
       appendAmountOfRainToForecast: false
@@ -13,14 +13,14 @@ class weatherForcasterService{
   }
 }
 
-class featureAwareWeatherForcasterServiceFactory{
+class featureAwareWeatherForecasterServiceFactory{
   build() {
     const options = {
       appendAmountOfRainToForecast: featureDecisions.appendAmountOfRainToForecast()
     }
 
-    return new weatherForcasterService(options);
+    return new weatherForecasterService(options);
   }
 }
 
-const weatherForecaster = new featureAwareWeatherForcasterServiceFactory().build();
+const weatherForecaster = new featureAwareWeatherForecasterServiceFactory().build();
diff --git a/groundwork.js b/groundwork.js
@@ -6,13 +6,13 @@ function appendAmountOfRain(forecast) {
   return `${forecast} with 3cm of rain`;
 }
 
-const weatherForcasterService = {
-  generateWeatherForecast: function (location) {
+class weatherForcasterService{
+  generateWeatherForecast(location) {
     const forecast = buildForecast(location);
     // We have been asked to insert appendAmountOfRain(...) here
     return forecast;
   }
 }
 
-const weatherForecaster = weatherForcasterService;
+const weatherForecaster = new weatherForcasterService();
 console.log(weatherForecaster.generateWeatherForecast("Minnesota"))
diff --git a/v2.js b/v2.js
@@ -1,6 +1,6 @@
 const features = getFeatureFlagServiceFromSomewhere()
-const weatherForcasterService = {
-  generateWeatherForecast: function (location) {
+class weatherForcasterService{
+  generateWeatherForecast(location) {
     let forecast = buildForecast(location);
     if(features.isEnabled("amount-of-rain")) {
       forecast = appendAmountOfRain(forecast)

diff --git a/v3.js b/v3.js
@@ -1,6 +1,6 @@
 const featureDecisions = getFeatureDecisionServiceFromSomewhere()
-const weatherForcasterService = {
-  generateWeatherForecast: function (location) {
+class weatherForcasterService{
+  generateWeatherForecast(location) {
     let forecast = buildForecast(location);
     if(featureDecisions.appendAmountOfRainToForecast()) {
       forecast = appendAmountOfRain(forecast)

diff --git a/v4.js b/v4.js
@@ -0,0 +1,26 @@
+class weatherForcasterService{  
+  constructor(options) {
+    this.options = options ?? {
+      appendAmountOfRainToForecast: false
+    }
+  }
+  generateWeatherForecast(location) {
+    let forecast = buildForecast(location);
+    if(this.options.appendAmountOfRainToForecast) {
+      forecast = appendAmountOfRain(forecast)
+    }
+    return forecast;
+  }
+}
+
+class featureAwareWeatherForcasterServiceFactory{
+  build() {
+    const options = {
+      appendAmountOfRainToForecast: featureDecisions.appendAmountOfRainToForecast()
+    }
+
+    return new weatherForcasterService(options);
+  }
+}
+
+const weatherForecaster = new featureAwareWeatherForcasterServiceFactory().build();
diff --git a/v1.js b/v1.js
@@ -1,7 +1,9 @@
-function generateWeatherForecast(location) {
-  let forecast = buildForecast(location);
-  if(process.env.CURRENT_ENVIRONMENT === "nonprod") {
-    forecast = appendAmountOfRain(forecast)
+const weatherForcasterService = {
+  generateWeatherForecast: function (location) {
+    let forecast = buildForecast(location);
+    if(process.env.CURRENT_ENVIRONMENT === "nonprod") {
+      forecast = appendAmountOfRain(forecast)
+    }
+    return forecast;
   }
-  return forecast;
 }
diff --git a/groundwork.js b/groundwork.js
@@ -14,5 +14,5 @@ const weatherForcasterService = {
   }
 }
 
-const weatherForecaster = weatherForcasterService
+const weatherForecaster = weatherForcasterService;
 console.log(weatherForecaster.generateWeatherForecast("Minnesota"))
diff --git a/groundwork.js b/groundwork.js
@@ -14,4 +14,5 @@ const weatherForcasterService = {
   }
 }
 
-console.log(weatherForcasterService.generateWeatherForecast("Minnesota"))
+const weatherForecaster = weatherForcasterService
+console.log(weatherForecaster.generateWeatherForecast("Minnesota"))
diff --git a/groundwork.js b/groundwork.js
@@ -14,9 +14,4 @@ const weatherForcasterService = {
   }
 }
 
-function retrieveWeatherForecaster() {
-  return weatherForcasterService;
-}
-
-const weatherForecaster = retrieveWeatherForecaster()
-console.log(weatherForecaster.generateWeatherForecast("Minnesota"))
+console.log(weatherForcasterService.generateWeatherForecast("Minnesota"))
diff --git a/groundwork.js b/groundwork.js
@@ -6,8 +6,17 @@ function appendAmountOfRain(forecast) {
   return `${forecast} with 3cm of rain`;
 }
 
-function generateWeatherForecast(location) {
-  const forecast = buildForecast(location);
-  // We have been asked to insert appendAmountOfRain(...) here
-  return forecast;
-}
+const weatherForcasterService = {
+  generateWeatherForecast: function (location) {
+    const forecast = buildForecast(location);
+    // We have been asked to insert appendAmountOfRain(...) here
+    return forecast;
+  }
+}
+
+function retrieveWeatherForecaster() {
+  return weatherForcasterService;
+}
+
+const weatherForecaster = retrieveWeatherForecaster()
+console.log(weatherForecaster.generateWeatherForecast("Minnesota"))
diff --git a/v2.js b/v2.js
@@ -1,8 +1,10 @@
 const features = getFeatureFlagServiceFromSomewhere()
-function generateWeatherForecast(location) {
-  let forecast = buildForecast(location);
-  if(features.isEnabled("amount-of-rain")) {
-    forecast = appendAmountOfRain(forecast)
+const weatherForcasterService = {
+  generateWeatherForecast: function (location) {
+    let forecast = buildForecast(location);
+    if(features.isEnabled("amount-of-rain")) {
+      forecast = appendAmountOfRain(forecast)
+    }
+    return forecast;
   }
-  return forecast;
 }
diff --git a/v3.js b/v3.js
@@ -1,8 +1,10 @@
 const featureDecisions = getFeatureDecisionServiceFromSomewhere()
-function generateWeatherForecast(location) {
-  let forecast = buildForecast(location);
-  if(featureDecisions.appendAmountOfRainToForecast()) {
-    forecast = appendAmountOfRain(forecast)
+const weatherForcasterService = {
+  generateWeatherForecast: function (location) {
+    let forecast = buildForecast(location);
+    if(featureDecisions.appendAmountOfRainToForecast()) {
+      forecast = appendAmountOfRain(forecast)
+    }
+    return forecast;
   }
-  return forecast;
 }
diff --git a/v3.js b/v3.js
@@ -0,0 +1,8 @@
+const featureDecisions = getFeatureDecisionServiceFromSomewhere()
+function generateWeatherForecast(location) {
+  let forecast = buildForecast(location);
+  if(featureDecisions.appendAmountOfRainToForecast()) {
+    forecast = appendAmountOfRain(forecast)
+  }
+  return forecast;
+}
diff --git a/v3_featuredecision.js b/v3_featuredecision.js
@@ -0,0 +1,11 @@
+const features = getFeatureFlagServiceFromSomewhere()
+
+const featureDecisionObject = {
+  appendAmountOfRainToForecast: function() {
+    return features.isEnabled("amount-of-rain")
+  }
+}
+
+function getFeatureDecisionServiceFromSomewhere() {
+  return featureServiceObject
+}
diff --git a/v2.js b/v2.js
@@ -1,4 +1,4 @@
-const features = getFeatureServiceFromSomewhere()
+const features = getFeatureFlagServiceFromSomewhere()
 function generateWeatherForecast(location) {
   let forecast = buildForecast(location);
   if(features.isEnabled("amount-of-rain")) {

diff --git a/v2_service.js b/v2_service.js
@@ -8,6 +8,6 @@ const featureServiceObject = {
   }
 }
 
-function getFeatureServiceFromSomewhere() {
+function getFeatureFlagServiceFromSomewhere() {
   return featureServiceObject;
 }
diff --git a/groundwork.js b/groundwork.js
@@ -2,7 +2,12 @@ function buildForecast(location) {
   return `The forecast for ${location} is "cloudy"`;
 }
 
+function appendAmountOfRain(forecast) {
+  return `${forecast} with 3cm of rain`;
+}
+
 function generateWeatherForecast(location) {
   const forecast = buildForecast(location);
+  // We have been asked to insert appendAmountOfRain(...) here
   return forecast;
 }
diff --git a/v1.js b/v1.js
@@ -1,11 +1,3 @@
-function buildForecast(location) {
-  return `The forecast for ${location} is "cloudy"`;
-}
-
-function appendAmountOfRain(forecast) {
-  return `${forecast} with 3cm of rain`;
-}
-
 function generateWeatherForecast(location) {
   let forecast = buildForecast(location);
   if(process.env.CURRENT_ENVIRONMENT === "nonprod") {

diff --git a/v2.js b/v2.js
@@ -1,11 +1,3 @@
-function buildForecast(location) {
-  return `The forecast for ${location} is "cloudy"`;
-}
-
-function appendAmountOfRain(forecast) {
-  return `${forecast} with 3cm of rain`;
-}
-
 const features = getFeatureServiceFromSomewhere()
 function generateWeatherForecast(location) {
   let forecast = buildForecast(location);

diff --git a/v2_service.js b/v2_service.js
@@ -3,7 +3,7 @@ function environemntIsNonProduction() {
 }
 
 const featureServiceObject = {
-  isEnabled: function(toggleName) {
+  isEnabled: function(flagName) {
     return environemntIsNonProduction()
   }
 }

diff --git a/v2.js b/v2.js
@@ -6,6 +6,7 @@ function appendAmountOfRain(forecast) {
   return `${forecast} with 3cm of rain`;
 }
 
+const features = getFeatureServiceFromSomewhere()
 function generateWeatherForecast(location) {
   let forecast = buildForecast(location);
   if(features.isEnabled("amount-of-rain")) {

diff --git a/v2_service.js b/v2_service.js
@@ -1,9 +1,13 @@
 function environemntIsNonProduction() {
-  return false
+  return process.env.CURRENT_ENVIRONMENT === "nonprod";
 }
 
-const features = {
+const featureServiceObject = {
   isEnabled: function(toggleName) {
     return environemntIsNonProduction()
   }
+}
+
+function getFeatureServiceFromSomewhere() {
+  return featureServiceObject;
 }
diff --git a/v2.js b/v2.js
@@ -1,20 +1,3 @@
-function environemntIsNonProduction() {
-  return false
-}
-
-// Some nonsense builder function to get this example rolling
-function featureToggleService() {
-  const fnName = "isEnabled";
-  const someObj = {};
-  someObj[fnName] = function(toggleName) { 
-    // For any toggle, just check the env var
-    return environemntIsNonProduction()
-  };
-  return someObj;
-}
-
-const features = featureToggleService()
-
 function buildForecast(location) {
   return `The forecast for ${location} is "cloudy"`;
 }

diff --git a/v2_service.js b/v2_service.js
@@ -0,0 +1,9 @@
+function environemntIsNonProduction() {
+  return false
+}
+
+const features = {
+  isEnabled: function(toggleName) {
+    return environemntIsNonProduction()
+  }
+}
diff --git a/groundwork.js b/groundwork.js
@@ -1,3 +1,7 @@
+function buildForecast(location) {
+  return `The forecast for ${location} is "cloudy"`;
+}
+
 function generateWeatherForecast(location) {
   const forecast = buildForecast(location);
   return forecast;

diff --git a/v1.js b/v1.js
@@ -1,3 +1,11 @@
+function buildForecast(location) {
+  return `The forecast for ${location} is "cloudy"`;
+}
+
+function appendAmountOfRain(forecast) {
+  return `${forecast} with 3cm of rain`;
+}
+
 function generateWeatherForecast(location) {
   let forecast = buildForecast(location);
   if(process.env.CURRENT_ENVIRONMENT === "nonprod") {

diff --git a/v2.js b/v2.js
@@ -0,0 +1,32 @@
+function environemntIsNonProduction() {
+  return false
+}
+
+// Some nonsense builder function to get this example rolling
+function featureToggleService() {
+  const fnName = "isEnabled";
+  const someObj = {};
+  someObj[fnName] = function(toggleName) { 
+    // For any toggle, just check the env var
+    return environemntIsNonProduction()
+  };
+  return someObj;
+}
+
+const features = featureToggleService()
+
+function buildForecast(location) {
+  return `The forecast for ${location} is "cloudy"`;
+}
+
+function appendAmountOfRain(forecast) {
+  return `${forecast} with 3cm of rain`;
+}
+
+function generateWeatherForecast(location) {
+  let forecast = buildForecast(location);
+  if(features.isEnabled("amount-of-rain")) {
+    forecast = appendAmountOfRain(forecast)
+  }
+  return forecast;
+}
diff --git a/groundwork.js b/groundwork.js
@@ -0,0 +1,4 @@
+function generateWeatherForecast(location) {
+  const forecast = buildForecast(location);
+  return forecast;
+}
diff --git a/v1.js b/v1.js
@@ -0,0 +1,7 @@
+function generateWeatherForecast(location) {
+  let forecast = buildForecast(location);
+  if(process.env.CURRENT_ENVIRONMENT === "nonprod") {
+    forecast = appendAmountOfRain(forecast)
+  }
+  return forecast;
+}
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		This Gist and the associated were created to support an article on Feature Flags (to be linked)
		This Gist and the associated files were created to support an article on Feature Flags (to be linked)
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		This Gist and the associated were created to support an article on Feature Flags (to be linked)