aleenprd · October 24, 2022 18:11 · Oct 24, 2022 · Oct 24, 2022
diff --git a/scraper_abstract_class.py → scraper_base_class.py b/scraper_abstract_class.py → scraper_base_class.py
@@ -8,8 +8,8 @@ class ImdbScraperException(ScraperException):
     pass
 
 
-class Scraper(ABC):
-    """Abstract class meant to be parent of various other scrapers.
+class Scraper():
+    """Class meant to be parent of various other scrapers.
     
     Attributes:
         chromedriver (chromedriver): a Chrome webdriver for Selenium.
@@ -38,24 +38,4 @@ def fetch_el_if_available(soup: BeautifulSoup, element_type: str, class_type: st
         if element is not None:
             element = element.text
 
-        return element
-
-    def make_soup_with_selenium(self, url: str) -> BeautifulSoup:
-        """Return an HTML body from an URL.
-        
-        Args:
-            url (str): string representation of a URL address.
-        
-        Returns:
-            soup (BeautifulSoup): scraped webpage via bs4.
-        """
-        # You can either use a driver (write your one coad) like this 
-        # or install one (Chromedriver, Safari, etc.)
-        self.chromedriver.maximize_window()
-        self.chromedriver.get(url)
-        sleep(5)  # We want to give the page some time to load up
-
-        page_source = self.chromedriver.page_source
-        soup = BeautifulSoup(page_source, 'lxml')
-
-        return soup
+        return element
diff --git a/scraper_abstract_class.py b/scraper_abstract_class.py
@@ -0,0 +1,61 @@
+class ScraperException(Exception):
+    """Starting point for Scraper exceptions."""
+    pass
+
+
+class ImdbScraperException(ScraperException):
+    """Starting point for Scraper exceptions."""
+    pass
+
+
+class Scraper(ABC):
+    """Abstract class meant to be parent of various other scrapers.
+    
+    Attributes:
+        chromedriver (chromedriver): a Chrome webdriver for Selenium.
+        
+    Methods:
+        make_soup_with_selenium
+        @staticmethod fetch_el_if_available
+    """
+    def __init__(self):
+        driver_service = Service(ChromeDriverManager().install())
+        self.chromedriver = webdriver.Chrome(service=driver_service)
+
+    @staticmethod
+    def fetch_el_if_available(soup: BeautifulSoup, element_type: str, class_type: str):
+        """Returns element text if found, otherwise returns None.
+        
+        Args:
+            soup (BeautifulSoup): a b24 soup.
+            element_type (str): HTML type e.g. 'div'.
+            class_type (str): the class of the desired element.
+            
+        Returns:
+            element (str): text inside element.
+        """
+        element = soup.find(element_type, class_type)
+        if element is not None:
+            element = element.text
+
+        return element
+
+    def make_soup_with_selenium(self, url: str) -> BeautifulSoup:
+        """Return an HTML body from an URL.
+        
+        Args:
+            url (str): string representation of a URL address.
+        
+        Returns:
+            soup (BeautifulSoup): scraped webpage via bs4.
+        """
+        # You can either use a driver (write your one coad) like this 
+        # or install one (Chromedriver, Safari, etc.)
+        self.chromedriver.maximize_window()
+        self.chromedriver.get(url)
+        sleep(5)  # We want to give the page some time to load up
+
+        page_source = self.chromedriver.page_source
+        soup = BeautifulSoup(page_source, 'lxml')
+
+        return soup
No results found