andreisebastianc · May 2, 2020 17:11 · Oct 26, 2018 · Oct 24, 2018 · Oct 24, 2018 · Oct 24, 2018
diff --git a/pull_request_template.md b/pull_request_template.md
@@ -9,7 +9,7 @@
 - [ ] qunit tests pass 
 - [ ] lint tests pass
 - [ ] all requests are mocked using Mirage
-- [ ] commits have [good description](https://chris.beams.io/posts/git-commit/#seven-rules)
+- [ ] commits follow the [Conventional Commits Spec](https://www.conventionalcommits.org/en/v1.0.0-beta.2/)
 
 ## Change summary (mark all that apply)
 

diff --git a/pull_request_template.md b/pull_request_template.md
@@ -6,7 +6,7 @@
 
 ## DEV Checklist (all are mandatory)
 
-- [x] qunit tests pass 
+- [ ] qunit tests pass 
 - [ ] lint tests pass
 - [ ] all requests are mocked using Mirage
 - [ ] commits have [good description](https://chris.beams.io/posts/git-commit/#seven-rules)

diff --git a/pull_request_template.md b/pull_request_template.md
@@ -6,7 +6,7 @@
 
 ## DEV Checklist (all are mandatory)
 
-- [ ] qunit tests pass 
+- [x] qunit tests pass 
 - [ ] lint tests pass
 - [ ] all requests are mocked using Mirage
 - [ ] commits have [good description](https://chris.beams.io/posts/git-commit/#seven-rules)

diff --git a/pull_request_template.md b/pull_request_template.md
@@ -6,7 +6,7 @@
 
 ## DEV Checklist (all are mandatory)
 
-- [x] qunit tests pass 
+- [ ] qunit tests pass 
 - [ ] lint tests pass
 - [ ] all requests are mocked using Mirage
 - [ ] commits have [good description](https://chris.beams.io/posts/git-commit/#seven-rules)

diff --git a/pull_request_template.md b/pull_request_template.md
@@ -6,7 +6,7 @@
 
 ## DEV Checklist (all are mandatory)
 
-- [ ] qunit tests pass 
+- [x] qunit tests pass 
 - [ ] lint tests pass
 - [ ] all requests are mocked using Mirage
 - [ ] commits have [good description](https://chris.beams.io/posts/git-commit/#seven-rules)

diff --git a/pull_request_template.md b/pull_request_template.md
@@ -2,7 +2,7 @@
 | :---: | :---: | :---: |
 | Ready/Hold | Feature/Bug/Tooling/Refactor/Hotfix | [Link](<ticket link here>) |
 
-> ⚠️ NOTE: use notes like this to emphasize something about the PR. This could include other PRs this PR is built on top of; new or removed environment variables; reasons for why the PR is on hold; or anything else you would like to draw attention to.
+> NOTE: use notes like this to emphasize something about the PR. This could include other PRs this PR is built on top of; new or removed environment variables; reasons for why the PR is on hold; or anything else you would like to draw attention to.
 
 ## DEV Checklist (all are mandatory)
 
@@ -14,7 +14,7 @@
 ## Change summary (mark all that apply)
 
 #### Layout
-> ⚠️ NOTE: if common CSS was changed, it's implied that it's been verified that layout was is not broken on other devices
+> NOTE: if common CSS was changed, it's implied that it's been verified that layout was is not broken on other devices
 - [ ] ⚠️ desktop only layout changes
 - [ ] ⚠️ tablet only layout changes
 - [ ] ⚠️ mobile only layout changes
@@ -31,13 +31,13 @@
 **BEFORE**:
 
 [insert screenshot here]
-> ⚠️ NOTE: use this only when a big, noticeable change is applied to the current UI
+> NOTE: use this only when a big, noticeable change is applied to the current UI
 
 **AFTER**:
 [insert screenshot here]
 
 ## New work items logged
-> ⚠️ NOTE: list new items that were logged in Jira as followup
+> NOTE: list new items that were logged in Jira as followup
 
 ## Other changes
 

diff --git a/pull_request_template.md b/pull_request_template.md
@@ -1,5 +1,5 @@
 | Status  | Type  |  Ticket |
-| :---: | :---: | :---: | :--: | :--: |
+| :---: | :---: | :---: |
 | Ready/Hold | Feature/Bug/Tooling/Refactor/Hotfix | [Link](<ticket link here>) |
 
 > ⚠️ NOTE: use notes like this to emphasize something about the PR. This could include other PRs this PR is built on top of; new or removed environment variables; reasons for why the PR is on hold; or anything else you would like to draw attention to.

diff --git a/pull_request_template.md b/pull_request_template.md
@@ -0,0 +1,50 @@
+| Status  | Type  |  Ticket |
+| :---: | :---: | :---: | :--: | :--: |
+| Ready/Hold | Feature/Bug/Tooling/Refactor/Hotfix | [Link](<ticket link here>) |
+
+> ⚠️ NOTE: use notes like this to emphasize something about the PR. This could include other PRs this PR is built on top of; new or removed environment variables; reasons for why the PR is on hold; or anything else you would like to draw attention to.
+
+## DEV Checklist (all are mandatory)
+
+- [ ] qunit tests pass 
+- [ ] lint tests pass
+- [ ] all requests are mocked using Mirage
+- [ ] commits have [good description](https://chris.beams.io/posts/git-commit/#seven-rules)
+
+## Change summary (mark all that apply)
+
+#### Layout
+> ⚠️ NOTE: if common CSS was changed, it's implied that it's been verified that layout was is not broken on other devices
+- [ ] ⚠️ desktop only layout changes
+- [ ] ⚠️ tablet only layout changes
+- [ ] ⚠️ mobile only layout changes
+- [ ] I've checked layout changes on all devices
+
+#### Tests
+- [ ] Did not add new tests / open for suggestions on tests to add
+
+#### Other
+- [ ] Solution required discussion with team members
+
+## Screenshots
+
+**BEFORE**:
+
+[insert screenshot here]
+> ⚠️ NOTE: use this only when a big, noticeable change is applied to the current UI
+
+**AFTER**:
+[insert screenshot here]
+
+## New work items logged
+> ⚠️ NOTE: list new items that were logged in Jira as followup
+
+## Other changes
+
+**New dependencies**:
+
+- `dependency` : dependency details
+
+**New dev dependencies**:
+
+- `dependency` : dependency details