bellbind · June 20, 2024 18:22 · Oct 9, 2015 · Oct 6, 2015 · Oct 2, 2015 · Oct 2, 2015
diff --git a/timer-and-promise.cc b/timer-and-promise.cc
@@ -6,13 +6,12 @@
 
 // Promise returned function
 NAN_METHOD(Wait) {
-  using ResolverPersistent = v8::Persistent<v8::Promise::Resolver>;
-  using ResolverLocal = v8::Local<v8::Promise::Resolver>;
+  using ResolverPersistent = Nan::Persistent<v8::Promise::Resolver>;
 
   auto ms = Nan::To<unsigned>(info[0]).FromJust();
   auto resolver = v8::Promise::Resolver::New(info.GetIsolate());
   auto promise = resolver->GetPromise();
-  auto persistent = new ResolverPersistent(info.GetIsolate(), resolver);
+  auto persistent = new ResolverPersistent(resolver);
 
   uv_timer_t* handle = new uv_timer_t;
   handle->data = persistent;
@@ -28,7 +27,7 @@ NAN_METHOD(Wait) {
     uv_close(reinterpret_cast<uv_handle_t*>(handle),
              [](uv_handle_t* handle) -> void {delete handle;});
 
-    auto resolver = ResolverLocal::New(v8::Isolate::GetCurrent(), *persistent);
+    auto resolver = Nan::New(*persistent);
     resolver->Resolve(Nan::New("invoked").ToLocalChecked());
 
     persistent->Reset();

diff --git a/readme.md b/readme.md
@@ -1,3 +1,26 @@
+# Native Module with libuv and Promise
+
+- `v8::Persistent`: Keep a v8 Object over scope
+    - it require to release the Object manulally with `Reset(void)`
+    - Use Object with convert Local to `v8::Local<T>::New(isolate, persistent)`
+- `v8::Promise` is made from `v8::Promise::Resolver` object
+    - `Promise::Resolver::New(isolate)` then `resolver->GetPromise()`
+    - use `ressolver->Resolve(obj)` or `resolver->Reject(obj)` to pass promise
+- `v8::Isolate`: requires to create v8 Object
+    - hidden by `Nan::New` inside to use `v8::Isolate::GetCurrent()`
+    - (for creating Isolate as barrier (e.f. for different tasks))
+- `Nan::HandleScope scope`: It requires to create v8 Object
+   in outside of NAN_METHOD function (e.g. in native callbacks)
+- `libuv` pattern
+    - make `uv_xxx_t` handle
+    - set `handle->data` to objects use inside callback
+    - call `uv_xxx_init(uv_default_loop(), handle)`
+    - call `uv_xxx_yyy(handle, callback, ...)` function
+    - in callback
+        - retrieve objects from `handle->data`
+        - `uv_close(handle, dispose)` to register deleting handle memory
+        - do something as callback        
+
 ## Reference
 
 For native module basics, see:

diff --git a/run.js b/run.js
@@ -1,4 +1,5 @@
 "use strict";
 
 let m = require(".");
-m.wait(10).then((msg) => console.log(`OK: ${msg}`));
+let start = Date.now();
+m.wait(500).then((msg) => console.log(`${Date.now() - start}ms OK: ${msg}`));
diff --git a/timer-and-promise.cc b/timer-and-promise.cc
@@ -1,39 +1,39 @@
 // build: npm install
 
+#include <iostream>
 #include <nan.h>
 
-// callback for uv_timer
-void timercb(uv_timer_t* handle) {
-  Nan::HandleScope scope;
-
-  auto persistent =
-    static_cast<v8::Persistent<v8::Promise::Resolver>*>(handle->data);
-
-  uv_timer_stop(handle);
-  uv_close(reinterpret_cast<uv_handle_t*>(handle),
-           [](uv_handle_t* handle) -> void {delete handle;});
-
-  auto resolver =
-    v8::Local<v8::Promise::Resolver>::New(v8::Isolate::GetCurrent(),
-                                          *persistent);
-  resolver->Resolve(Nan::New("invoked").ToLocalChecked());
-
-  persistent->Reset();
-  delete persistent;
-}
 
 // Promise returned function
 NAN_METHOD(Wait) {
+  using ResolverPersistent = v8::Persistent<v8::Promise::Resolver>;
+  using ResolverLocal = v8::Local<v8::Promise::Resolver>;
+
   auto ms = Nan::To<unsigned>(info[0]).FromJust();
-
   auto resolver = v8::Promise::Resolver::New(info.GetIsolate());
   auto promise = resolver->GetPromise();
-  auto persistent = new v8::Persistent<v8::Promise::Resolver>();
-  persistent->Reset(info.GetIsolate(), resolver);
-
+  auto persistent = new ResolverPersistent(info.GetIsolate(), resolver);
+
   uv_timer_t* handle = new uv_timer_t;
   handle->data = persistent;
   uv_timer_init(uv_default_loop(), handle);
+
+  // use capture-less lambda for c-callback
+  auto timercb = [](uv_timer_t* handle) -> void {
+    Nan::HandleScope scope;
+
+    auto persistent = static_cast<ResolverPersistent*>(handle->data);
+
+    uv_timer_stop(handle);
+    uv_close(reinterpret_cast<uv_handle_t*>(handle),
+             [](uv_handle_t* handle) -> void {delete handle;});
+
+    auto resolver = ResolverLocal::New(v8::Isolate::GetCurrent(), *persistent);
+    resolver->Resolve(Nan::New("invoked").ToLocalChecked());
+
+    persistent->Reset();
+    delete persistent;
+  };
   uv_timer_start(handle, timercb, ms, 0);
 
   info.GetReturnValue().Set(promise);

diff --git a/run.js b/run.js
@@ -1,4 +1,4 @@
-use strict";
+"use strict";
 
 let m = require(".");
 m.wait(10).then((msg) => console.log(`OK: ${msg}`));
diff --git a/binding.gyp b/binding.gyp
@@ -0,0 +1,18 @@
+# -*- mode: python -*-
+{
+    "targets": [
+        {
+            "include_dirs": ["<!(node -e \"require('nan')\")"],
+            "target_name": "TimerAndPromise",
+            "sources": [
+                "timer-and-promise.cc"
+            ],
+            "conditions": [
+                ["OS != 'win'",{
+                    "cflags": ["-Wall", "-Wextra", "-pedantic"],
+                    "cflags_cc": ["-std=c++14"],
+                }]
+            ],
+        },
+    ],
+}
diff --git a/package.json b/package.json
@@ -0,0 +1,12 @@
+{
+    "name": "timer-and-promise",
+    "version": "0.1.0",
+    "description": "Native module example with libuv uv_timer and promise",
+    "license": "MIT",
+    "repository": "gist:",
+    "engine": {"node": ">=4.0.0"},
+    "main": "./build/Release/TimerAndPromise",
+    "dependencies": {
+        "nan": ">=2.0.0"
+    }
+}
diff --git a/readme.md b/readme.md
@@ -0,0 +1,11 @@
+## Reference
+
+For native module basics, see:
+
+- https://gist.github.com/bellbind/cc915d252eeb77a3e03e
+
+For APIs, see:
+
+- http://docs.libuv.org/en/v1.x/timer.html
+- http://v8.paulfryzel.com/docs/master/classv8_1_1_persistent_base.html
+- http://v8.paulfryzel.com/docs/master/classv8_1_1_promise_1_1_resolver.html
diff --git a/run.js b/run.js
@@ -0,0 +1,4 @@
+use strict";
+
+let m = require(".");
+m.wait(10).then((msg) => console.log(`OK: ${msg}`));
diff --git a/timer-and-promise.cc b/timer-and-promise.cc
@@ -0,0 +1,47 @@
+// build: npm install
+
+#include <nan.h>
+
+// callback for uv_timer
+void timercb(uv_timer_t* handle) {
+  Nan::HandleScope scope;
+
+  auto persistent =
+    static_cast<v8::Persistent<v8::Promise::Resolver>*>(handle->data);
+
+  uv_timer_stop(handle);
+  uv_close(reinterpret_cast<uv_handle_t*>(handle),
+           [](uv_handle_t* handle) -> void {delete handle;});
+
+  auto resolver =
+    v8::Local<v8::Promise::Resolver>::New(v8::Isolate::GetCurrent(),
+                                          *persistent);
+  resolver->Resolve(Nan::New("invoked").ToLocalChecked());
+
+  persistent->Reset();
+  delete persistent;
+}
+
+// Promise returned function
+NAN_METHOD(Wait) {
+  auto ms = Nan::To<unsigned>(info[0]).FromJust();
+
+  auto resolver = v8::Promise::Resolver::New(info.GetIsolate());
+  auto promise = resolver->GetPromise();
+  auto persistent = new v8::Persistent<v8::Promise::Resolver>();
+  persistent->Reset(info.GetIsolate(), resolver);
+
+  uv_timer_t* handle = new uv_timer_t;
+  handle->data = persistent;
+  uv_timer_init(uv_default_loop(), handle);
+  uv_timer_start(handle, timercb, ms, 0);
+
+  info.GetReturnValue().Set(promise);
+}
+
+
+NAN_MODULE_INIT(InitAll) {
+  Nan::Export(target, "wait", Wait);
+}
+
+NODE_MODULE(TimerAndPromise, InitAll)
No results found