bts · September 30, 2011 21:20 · Sep 30, 2011 · Sep 30, 2011 · Sep 30, 2011 · Sep 30, 2011
diff --git a/option1.rb b/option1.rb
@@ -1,5 +1,5 @@
-# If I'm writing a plugin, I'd typically like to have a namespace to add my
-# own classes, so I would skip this option:
+# bts: If I'm writing a plugin, I'd typically like to have a namespace to add
+# my own classes, so I would skip this option:
 
 # Qu.plugin(:autoretry) do |*errors|
 #   options = {:limit => 3}.merge!(errors.extract_options!)

diff --git a/option1.rb b/option1.rb
@@ -1,12 +1,15 @@
-Qu.plugin(:autoretry) do |*errors|
-  options = {:limit => 3}.merge!(errors.extract_options!)
-  errors << Exception if errors.empty?
+# If I'm writing a plugin, I'd typically like to have a namespace to add my
+# own classes, so I would skip this option:
 
-  before :failure do |job, e|
-    if errors.any? {|error| error === e }
-      job.data[:retries] += 1
-      Qu.requeue job unless job.config[:retries] >= limit
-      halt # don't report the error yet
-    end
-  end
-end
+# Qu.plugin(:autoretry) do |*errors|
+#   options = {:limit => 3}.merge!(errors.extract_options!)
+#   errors << Exception if errors.empty?
+
+#   before :failure do |job, e|
+#     if errors.any? {|error| error === e }
+#       job.data[:retries] += 1
+#       Qu.requeue job unless job.config[:retries] >= limit
+#       halt # don't report the error yet
+#     end
+#   end
+# end
diff --git a/option2.rb b/option2.rb
@@ -1,16 +1,25 @@
 class Qu::Plugin::AutoRetry < Qu::Plugin
-  plugin :autoretry
+  # bts: forego the following line, and introspect plugin name from class via
+  # underscoring the class' name
+  #
+  # plugin :autoretry
+
+  # bts: use "acts" class methods instead of registering callbacks in
+  # #initialize
+  before_failure :retry
+  before :failure, :retry
 
   attr_reader :errors, :options
 
   def initialize(*errors)
     @options = {:limit => 3}.merge!(errors.extract_options!)
     @errors << Exception if errors.empty?
 
-    before :failure, :retry
+    # bts: use class methods instead
+    #
+    # before :failure, :retry
   end
 
-
   def retry(job, e)
     if errors.any? {|error| error === e }
       job.data[:retries] += 1

diff --git a/usage.rb b/usage.rb
@@ -1,5 +1,10 @@
 class ProcessPresentation < Qu::Job
-  autoretry Timeout::Error, :times => 5
+  # bts: use convention of underscored class name, so we don't have to
+  # declare the plugin name twice in the Plugin (via class' name and also via
+  # the "plugin :autoretry" declaration)
+  #
+  auto_retry Timeout::Error, :times => 5
+  # autoretry Timeout::Error, :times => 5
 
   attr_reader :presentation
 

diff --git a/option2 → option2.rb b/option2 → option2.rb
diff --git a/gistfile1.rb → option1.rb b/gistfile1.rb → option1.rb
@@ -9,19 +9,4 @@
       halt # don't report the error yet
     end
   end
-end
-
-
-class ProcessPresentation < Qu::Job
-  autoretry Timeout::Error, :times => 5
-
-  attr_reader :presentation
-
-  def initialize(presentation_id)
-    @presentation = Presentation.find(presentation)
-  end
-
-  def perform
-    # …
-  end
-end
+end
diff --git a/option2 b/option2
@@ -0,0 +1,21 @@
+class Qu::Plugin::AutoRetry < Qu::Plugin
+  plugin :autoretry
+
+  attr_reader :errors, :options
+
+  def initialize(*errors)
+    @options = {:limit => 3}.merge!(errors.extract_options!)
+    @errors << Exception if errors.empty?
+
+    before :failure, :retry
+  end
+
+
+  def retry(job, e)
+    if errors.any? {|error| error === e }
+      job.data[:retries] += 1
+      Qu.requeue job unless job.config[:retries] >= limit
+      halt # don't report the error yet
+    end
+  end
+end
diff --git a/usage.rb b/usage.rb
@@ -0,0 +1,13 @@
+class ProcessPresentation < Qu::Job
+  autoretry Timeout::Error, :times => 5
+
+  attr_reader :presentation
+
+  def initialize(presentation_id)
+    @presentation = Presentation.find(presentation)
+  end
+
+  def perform
+    # …
+  end
+end
diff --git a/gistfile1.rb b/gistfile1.rb
@@ -0,0 +1,27 @@
+Qu.plugin(:autoretry) do |*errors|
+  options = {:limit => 3}.merge!(errors.extract_options!)
+  errors << Exception if errors.empty?
+
+  before :failure do |job, e|
+    if errors.any? {|error| error === e }
+      job.data[:retries] += 1
+      Qu.requeue job unless job.config[:retries] >= limit
+      halt # don't report the error yet
+    end
+  end
+end
+
+
+class ProcessPresentation < Qu::Job
+  autoretry Timeout::Error, :times => 5
+
+  attr_reader :presentation
+
+  def initialize(presentation_id)
+    @presentation = Presentation.find(presentation)
+  end
+
+  def perform
+    # …
+  end
+end
No results found