Skip to content

Instantly share code, notes, and snippets.

@crittermike
Forked from mirie/p2_drupal_pr_template.md
Created August 10, 2016 15:04
Show Gist options
  • Select an option

  • Save crittermike/0e15d91b4716c2ce948bc121b89f5e70 to your computer and use it in GitHub Desktop.

Select an option

Save crittermike/0e15d91b4716c2ce948bc121b89f5e70 to your computer and use it in GitHub Desktop.

Revisions

  1. @mirie mirie revised this gist Aug 10, 2016. 1 changed file with 1 addition and 1 deletion.
    2 changes: 1 addition & 1 deletion p2_drupal_pr_template.md
    Original file line number Diff line number Diff line change
    @@ -15,8 +15,8 @@
    - [ ] Has composer.lock been updated?
    - [ ] Have you run a test build locally to confirm that Composer downloads the necessary dependencies successfully?
    - [ ] Will this feature require a new piece of infrastructure be implemented? If so:
    - [ ] Have you already worked this out with the infrastructure team?
    - [ ] Have any infrastructure changes already been built and are ready for the change implemented here?
    - [ ] Is this change documented?

    * * *
    **Below is the template for a PR. Remove (or add) any sections as needed. Erase this line before submitting.**
  2. @mirie mirie revised this gist Aug 10, 2016. 1 changed file with 1 addition and 1 deletion.
    2 changes: 1 addition & 1 deletion p2_drupal_pr_template.md
    Original file line number Diff line number Diff line change
    @@ -42,4 +42,4 @@ URL to ticket(s):

    ##### Screenshots (if appropriate)

    ### How should this be manually tested?
    ## How should this be manually tested?
  3. @mirie mirie created this gist Aug 10, 2016.
    45 changes: 45 additions & 0 deletions p2_drupal_pr_template.md
    Original file line number Diff line number Diff line change
    @@ -0,0 +1,45 @@
    ## Definition of Done:
    *This section is for your verification before submitting a PR. Remove this before submitting:*
    - [ ] Has any required automated testing been written/updated?
    - [ ] Has the documentation been added/updated?
    - [ ] Is there appropriate logging included?
    - [ ] Does this add new modules/themes? If so:
    - [ ] Has the make file been updated?
    - [ ] Has the install profile's info file been updated?
    - [ ] Have you run a test build locally to confirm your new modules/themes get downloaded and enabled properly?
    - [ ] Does this add new configuration? If so:
    - [ ] Has all the required configuration been added?
    - [ ] Have you run a test build locally to confirm that the configuration gets installed correctly?
    - [ ] Does this add new Composer dependencies? If so:
    - [ ] Has composer.json been updated?
    - [ ] Has composer.lock been updated?
    - [ ] Have you run a test build locally to confirm that Composer downloads the necessary dependencies successfully?
    - [ ] Will this feature require a new piece of infrastructure be implemented? If so:
    - [ ] Have you already worked this out with the infrastructure team?
    - [ ] Have any infrastructure changes already been built and are ready for the change implemented here?

    * * *
    **Below is the template for a PR. Remove (or add) any sections as needed. Erase this line before submitting.**

    # Addresses Ticket(s):
    URL to ticket(s):

    ## Overview of work completed:

    #### Make file additions or New Custom Module Additions

    #### Database Updates to be Run

    #### Additions/Updates/Deletions of fields, data structures, etc:

    #### Other Configuration Changes

    #### JS Changes

    #### CSS Changes

    #### Other Miscellaneous Changes

    ##### Screenshots (if appropriate)

    ### How should this be manually tested?