davelnewton’s gists

davelnewton / indentation-works.js

Created September 28, 2020 17:06

Indentation helps find structural issues

	client.on('message', message => {
	if (!message.content.startsWith(prefix) \|\| message.author.bot) return

	let user = message.mentions.users.first()
	const args = message.content.slice(prefix.length).split(/ +/)
	const command = args.shift().toLowerCase()

	if (command === 'marry') {
	if (!user) return

davelnewton / cleanup.js

Created September 9, 2020 13:45

	const { details } = resp.Result

	const keyMatch = i =>
	`InternetGatewayDevice.TraceRouteDiagnostics.RouteHops.${i}.HopErrorCode`

	for (let i = 1; i < details.length; i++) {
	let resp2 = details.find(x => x.key == keyMatch(i)).value
	return resp2
	}

davelnewton / micro-readability-further-breakup.js

Created July 17, 2020 19:27

	function extractParamStrings(s) {
	if (s[0] === '?') s = s.slice(1, s.length)
	return s.split('&')
	}

	const extractParamKeyValPair = paramString =>
	paramString.split('=').map(decodeURIComponent)

	const addParam = (toObj, [key, val]) => {
	toObj[key] = val

davelnewton / micro-readability-final.js

Created July 17, 2020 19:11

	export function fromUrlQuery(str) {
	if (!str) return {}

	if (str[0] === '?') str = str.slice(1, str.length)

	return str.split('&').reduce((acc, vars) => {
	const [key, val] = vars.split('=').map(decodeURIComponent)
	acc[key] = val
	return acc
	}, {})

davelnewton / micro-readability-modern-js.js

Created July 17, 2020 19:08

	const ret = str.split('&').reduce((acc, vars) => {
	const [key, val] = vars.split('=').map(decodeURIComponent)
	console.log('fromURLQuery', { key, val })
	acc[key] = val
	return acc
	}, {})

davelnewton / micro-readability-fix-loop.js

Created July 17, 2020 19:07

	for (let i = 0; i < vars.length; i++) {
	let pair = vars[i].split('=').map(decodeURIComponent)
	ret[pair[0]] = pair[1]
	console.log('fromURLQuery', pair)
	}

davelnewton / micro-readability-fix-opening.js

Created July 17, 2020 19:05

	export function fromURLQuery(str) {
	console.log('fromURLQuery BEGIN', str)

	if (!str) {
	console.log('fromURLQuery return empty', ret)
	return {}
	}

davelnewton / microcode-readability-spaced-out.js

Created July 17, 2020 19:04

	export function fromURLQuery(str) {
	console.log('fromURLQuery BEGIN', str)

	let ret = {}
	if (!str) {
	console.log('fromURLQuery return empty', ret)
	return ret
	}

	if (str[0] === '?') str = str.slice(1, str.length)

davelnewton / micro-readability-original-code.js

Last active July 17, 2020 19:02

	export function fromURLQuery(str) {
	console.log('fromURLQuery BEGIN', str)
	let ret = {}
	if (!str) {
	console.log('fromURLQuery return empty', ret)
	return ret
	}
	if (str[0] === '?') str = str.slice(1, str.length)
	let vars = str.split('&')
	for (let i = 0; i < vars.length; i++) {

davelnewton / refactor-nasty-ifs.js

Last active April 24, 2019 09:57

Code Cleanup on Aisle 5

	const prices = {
	"Residential": 90,
	"Business": 150,
	}

	// TODO Handle no price found.
	const price = numberOfRooms * prices[propertyUsage]

	let discountMultiplier = 0
	if (numberOfRooms >= 10) {

Dave Newton davelnewton