elonmusk408 · February 25, 2021 10:44 · Apr 12, 2018 · Apr 2, 2018 · Apr 2, 2018 · Apr 2, 2018
diff --git a/qualityGates.groovy b/qualityGates.groovy
@@ -20,13 +20,14 @@
  *
  */
 def call() {
-    echo "Initializing quality gates..."
-    sh 'sleep 10' //small delay because project quality can still being published on previous stage (specially on bigger projects).  
-    def result = waitForQualityGate() //this is enabled by quality gates plugin: https://wiki.jenkins.io/display/JENKINS/Quality+Gates+Plugin
-    if (result.status != 'OK') {
-         error "Pipeline aborted due to quality gate failure: ${result.status}"
-    } else {
-         echo "Quality gate passed with result: ${result.status}"
+    timeout(time: 3, unit: 'MINUTES') {
+        echo "Initializing quality gates..."
+        sh 'sleep 10' //small delay because project quality can still being published on previous stage (specially on bigger projects).  
+        def result = waitForQualityGate() //this is enabled by quality gates plugin: https://wiki.jenkins.io/display/JENKINS/Quality+Gates+Plugin
+        if (result.status != 'OK') {
+             error "Pipeline aborted due to quality gate failure: ${result.status}"
+        } else {
+             echo "Quality gate passed with result: ${result.status}"
+        }
     }
-
 }
diff --git a/qualityGates.groovy b/qualityGates.groovy
@@ -1,7 +1,7 @@
 #!/usr/bin/env groovy
 
 /**
- * Fails the pipeline if project quality doesn't meet the configured quality profile (see https://docs.sonarqube.org/display/SONAR/Quality+Profiles).
+ * Fails the pipeline if project quality doesn't meet the configured quality profile (see https://docs.sonarqube.org/display/SONAR/Quality+Gates AND https://docs.sonarqube.org/display/SONAR/Quality+Profiles).
  * This DSL function must be invoked after the quality analisys has been published. Example:
  *
  * stage('sonar') { 

diff --git a/qualityGates.groovy b/qualityGates.groovy
@@ -2,7 +2,7 @@
 
 /**
  * Fails the pipeline if project quality doesn't meet the configured quality profile (see https://docs.sonarqube.org/display/SONAR/Quality+Profiles).
- * This DSL function must be invoked after the quality analisys has been published.
+ * This DSL function must be invoked after the quality analisys has been published. Example:
  *
  * stage('sonar') { 
  *     steps {

diff --git a/qualityGates.groovy b/qualityGates.groovy
@@ -22,7 +22,7 @@
 def call() {
     echo "Initializing quality gates..."
     sh 'sleep 10' //small delay because project quality can still being published on previous stage (specially on bigger projects).  
-    def result = waitForQualityGate()
+    def result = waitForQualityGate() //this is enabled by quality gates plugin: https://wiki.jenkins.io/display/JENKINS/Quality+Gates+Plugin
     if (result.status != 'OK') {
          error "Pipeline aborted due to quality gate failure: ${result.status}"
     } else {

diff --git a/qualityGates.groovy b/qualityGates.groovy
@@ -1,7 +1,7 @@
 #!/usr/bin/env groovy
 
 /**
- * Fails the pipeline if project quality doesn't meet the configured quality profile.
+ * Fails the pipeline if project quality doesn't meet the configured quality profile (see https://docs.sonarqube.org/display/SONAR/Quality+Profiles).
  * This DSL function must be invoked after the quality analisys has been published.
  *
  * stage('sonar') { 
@@ -14,7 +14,7 @@
  *
  * stage('quality-gates') {
  *     steps {
- *         qualityGates() //this stage will fail if project quality doesn't meet its quality profile (see https://docs.sonarqube.org/display/SONAR/Quality+Profiles)
+ *         qualityGates() //this stage will fail if project quality doesn't meet its quality profile
  *     }
  * }
  *

diff --git a/qualityGates.groovy b/qualityGates.groovy
@@ -20,8 +20,8 @@
  *
  */
 def call() {
-    echo "Iniciando quality gates..."
-    sh 'sleep 10'
+    echo "Initializing quality gates..."
+    sh 'sleep 10' //small delay because project quality can still being published on previous stage (specially on bigger projects).  
     def result = waitForQualityGate()
     if (result.status != 'OK') {
          error "Pipeline aborted due to quality gate failure: ${result.status}"

diff --git a/qualityGates.groovy b/qualityGates.groovy
@@ -0,0 +1,32 @@
+#!/usr/bin/env groovy
+
+/**
+ * Fails the pipeline if project quality doesn't meet the configured quality profile.
+ * This DSL function must be invoked after the quality analisys has been published.
+ *
+ * stage('sonar') { 
+ *     steps {
+ *         withSonarQubeEnv('sonar') { //there must be a tool named 'sonar' configured on Jenkins (/jenkins/configureTools) 
+ *            sh 'mvn sonar:sonar' //publish project quality on sonar
+ *        }
+ *     }
+ * }
+ *
+ * stage('quality-gates') {
+ *     steps {
+ *         qualityGates() //this stage will fail if project quality doesn't meet its quality profile (see https://docs.sonarqube.org/display/SONAR/Quality+Profiles)
+ *     }
+ * }
+ *
+ */
+def call() {
+    echo "Iniciando quality gates..."
+    sh 'sleep 10'
+    def result = waitForQualityGate()
+    if (result.status != 'OK') {
+         error "Pipeline aborted due to quality gate failure: ${result.status}"
+    } else {
+         echo "Quality gate passed with result: ${result.status}"
+    }
+
+}