garciparedes · May 4, 2019 10:09 · Mar 20, 2018 · Jun 28, 2012 · Jun 14, 2012 · Jun 14, 2012
diff --git a/gcd_and_lcm.py b/gcd_and_lcm.py
@@ -1,16 +1,45 @@
-# Greatest common divisor of more than 2 numbers.  Am I terrible for doing it this way?
+# Greatest common divisor of 1 or more numbers.
+from functools import reduce
+
 
 def gcd(*numbers):
-    """Return the greatest common divisor of the given integers"""
-    from fractions import gcd
+    """
+    Return the greatest common divisor of 1 or more integers
+
+    Examples
+    --------
+    >>> gcd(5)
+    5
+    >>> gcd(30, 40)
+    10
+    >>> gcd(120, 40, 60)
+    20
+    """
+    # Am I terrible for doing it this way?
+    from math import gcd
+
     return reduce(gcd, numbers)
 
-# Least common multiple is not in standard libraries? It's in gmpy, but this is simple enough:
+# Least common multiple is not in standard libraries? It's in gmpy, but this
+# is simple enough:
+
 
 def lcm(*numbers):
-    """Return lowest common multiple."""    
+    """
+    Return lowest common multiple of 1 or more integers.
+
+    Examples
+    --------
+    >>> lcm(5)
+    5
+    >>> lcm(30, 40)
+    120
+    >>> lcm(120, 40, 60)
+    120
+    """
     def lcm(a, b):
         return (a * b) // gcd(a, b)
+
     return reduce(lcm, numbers, 1)
 
-# Assuming numbers are positive integers...
+# Assuming numbers are positive integers...
diff --git a/gcd_and_lcm.py b/gcd_and_lcm.py
@@ -0,0 +1,16 @@
+# Greatest common divisor of more than 2 numbers.  Am I terrible for doing it this way?
+
+def gcd(*numbers):
+    """Return the greatest common divisor of the given integers"""
+    from fractions import gcd
+    return reduce(gcd, numbers)
+
+# Least common multiple is not in standard libraries? It's in gmpy, but this is simple enough:
+
+def lcm(*numbers):
+    """Return lowest common multiple."""    
+    def lcm(a, b):
+        return (a * b) // gcd(a, b)
+    return reduce(lcm, numbers, 1)
+
+# Assuming numbers are positive integers...
diff --git a/lcm.py b/lcm.py
@@ -1,11 +0,0 @@
-# LCM not in standard libraries? It's in gmpy, but this is simple enough:
-
-from fractions import gcd
-
-def lcm(*numbers):
-    """Return lowest common multiple."""    
-    def lcm(a, b):
-        return (a * b) // gcd(a, b)
-    return reduce(lcm, numbers, 1)
-
-# Assuming numbers are positive integers...

diff --git a/gcd and lcm.py → lcm.py b/gcd and lcm.py → lcm.py
diff --git a/gcd and lcm.py b/gcd and lcm.py
@@ -1,13 +1,11 @@
-# GCD and LCM are not in math module.  They are in gmpy, but these are simple enough:
+# LCM not in standard libraries? It's in gmpy, but this is simple enough:
 
-def gcd(a,b):
-    """Return the greatest common divisor of a and b"""
-    while b > 0:
-        a, b = b, a % b
-    return a
-
-def lcm(a, b):
-    """Return the lowest common multiple of a and b"""
-    return a * b / gcd(a, b)
+from fractions import gcd
 
-# Assuming a and b are positive integers...
+def lcm(*numbers):
+    """Return lowest common multiple."""    
+    def lcm(a, b):
+        return (a * b) // gcd(a, b)
+    return reduce(lcm, numbers, 1)
+
+# Assuming numbers are positive integers...
diff --git a/gcd and lcm.py b/gcd and lcm.py
@@ -10,3 +10,4 @@ def lcm(a, b):
     """Return the lowest common multiple of a and b"""
     return a * b / gcd(a, b)
 
+# Assuming a and b are positive integers...
diff --git a/gcd and lcm.py b/gcd and lcm.py
@@ -1,12 +1,12 @@
 # GCD and LCM are not in math module.  They are in gmpy, but these are simple enough:
 
 def gcd(a,b):
-    """Compute the greatest common divisor of a and b"""
+    """Return the greatest common divisor of a and b"""
     while b > 0:
         a, b = b, a % b
     return a
 
 def lcm(a, b):
-    """Compute the lowest common multiple of a and b"""
+    """Return the lowest common multiple of a and b"""
     return a * b / gcd(a, b)
 
diff --git a/gcd and lcm.py b/gcd and lcm.py
@@ -1,12 +1,12 @@
 # GCD and LCM are not in math module.  They are in gmpy, but these are simple enough:
 
 def gcd(a,b):
-    ''' Compute the greatest common divisor of a and b '''
+    """Compute the greatest common divisor of a and b"""
     while b > 0:
         a, b = b, a % b
     return a
 
 def lcm(a, b):
-    ''' Compute the lowest common multiple of a and b '''
+    """Compute the lowest common multiple of a and b"""
     return a * b / gcd(a, b)
 
diff --git a/gcd and lcm.py b/gcd and lcm.py
@@ -1,12 +1,12 @@
 # GCD and LCM are not in math module.  They are in gmpy, but these are simple enough:
 
 def gcd(a,b):
-    ''' Compute the greatest common divisor of a and b'''
+    ''' Compute the greatest common divisor of a and b '''
     while b > 0:
         a, b = b, a % b
     return a
 
 def lcm(a, b):
-    ''' Compute the lowest common multiple of a and b'''
+    ''' Compute the lowest common multiple of a and b '''
     return a * b / gcd(a, b)
 
diff --git a/gcd and lcm.py b/gcd and lcm.py
@@ -0,0 +1,12 @@
+# GCD and LCM are not in math module.  They are in gmpy, but these are simple enough:
+
+def gcd(a,b):
+    ''' Compute the greatest common divisor of a and b'''
+    while b > 0:
+        a, b = b, a % b
+    return a
+
+def lcm(a, b):
+    ''' Compute the lowest common multiple of a and b'''
+    return a * b / gcd(a, b)
+
No results found