Skip to content

Instantly share code, notes, and snippets.

@jessehouwing

jessehouwing/DoNotUseParseAndToStringToConvertTypesTests.cs

Created April 7, 2019 20:21
Show Gist options
  • Save jessehouwing/fe7a8c730832ab7771efa24b42a68a2f to your computer and use it in GitHub Desktop.
Save jessehouwing/fe7a8c730832ab7771efa24b42a68a2f to your computer and use it in GitHub Desktop.
Download ZIP

Revisions

  1. jessehouwing created this gist Apr 7, 2019.
    248 changes: 248 additions & 0 deletions DoNotUseParseAndToStringToConvertTypesTests.cs
    View file
    Original file line number Diff line number Diff line change
    @@ -0,0 +1,248 @@
    using System;
    using System.Text;
    using System.Collections.Generic;
    using System.Linq;
    using Microsoft.VisualStudio.TestTools.UnitTesting;
    using FxCopContrib.TestHarness;

    namespace FxCopContrib.Tests
    {
    /// <summary>
    /// Summary description for DoNotUseParseAndToStringToConvertTypes
    /// </summary>
    [TestClass]
    public class DoNotUseParseAndToStringToConvertTypesTests
    {
    private TestContext testContextInstance;

    /// <summary>
    ///Gets or sets the test context which provides
    ///information about and functionality for the current test run.
    ///</summary>
    public TestContext TestContext
    {
    get
    {
    return testContextInstance;
    }
    set
    {
    testContextInstance = value;
    }
    }

    [TestMethod]
    public void RuleShouldDetectDirectParseToString()
    {
    FxCopTest
    .ForRule<DoNotUseParseAndToStringToConvertTypes>()
    .OnMethod(
    @"
    public void TestMethod()
    {
    int i = int.Parse(1.ToString());
    }
    "
    )
    .WithReferencesTo(typeof(int), typeof(string))
    .WillFind(ProblemPrototype.Default)
    .Conclusive()
    .Verify();
    }

    [TestMethod]
    public void RuleShouldDetectDirectParseStringEmptyConcat()
    {
    FxCopTest
    .ForRule<DoNotUseParseAndToStringToConvertTypes>()
    .OnMethod(
    @"
    public void TestMethod()
    {
    int i = int.Parse(string.Empty + 1);
    }
    "
    )
    .WithReferencesTo(typeof(int), typeof(string))
    .WillFind(ProblemPrototype.Default)
    .Conclusive()
    .Verify();
    }

    [TestMethod]
    public void RuleShouldDetectDirectParseQuoteQuoteConcat()
    {
    FxCopTest
    .ForRule<DoNotUseParseAndToStringToConvertTypes>()
    .OnMethod(
    @"
    public void TestMethod()
    {
    int i = int.Parse("""" + 1);
    }
    "
    )
    .WithReferencesTo(typeof(int), typeof(string))
    .WillFind(ProblemPrototype.Default)
    .Conclusive()
    .Verify();
    }

    [TestMethod]
    public void RuleShouldDetectLocalTostringParse()
    {
    FxCopTest
    .ForRule<DoNotUseParseAndToStringToConvertTypes>()
    .OnMethod(
    @"
    public void TestMethod()
    {
    string value = 1.ToString();
    int i = int.Parse(value);
    }
    "
    )
    .WithReferencesTo(typeof(int), typeof(string))
    .WillFind(ProblemPrototype.Default)
    .Conclusive()
    .Verify();
    }

    [TestMethod]
    public void RuleShouldDetectLocalStringEmptyAppendParse()
    {
    var rule = new DoNotUseParseAndToStringToConvertTypes();

    FxCopTest
    .ForRule<DoNotUseParseAndToStringToConvertTypes>()
    .OnMethod(
    @"
    public void TestMethod()
    {
    string value = string.Empty + 1;
    int i = int.Parse(value);
    }
    "
    )
    .WithReferencesTo(typeof(int), typeof(string))
    .WillFind(ProblemPrototype.Default)
    .Conclusive()
    .Verify();
    }

    [TestMethod]
    public void RuleShouldDetectLocalQuoteQuoteConcatParse()
    {
    FxCopTest
    .ForRule<DoNotUseParseAndToStringToConvertTypes>()
    .OnMethod(
    @"
    public void TestMethod()
    {
    string value = """" + 1;
    int i = int.Parse(value);
    }
    "
    )
    .WithReferencesTo(typeof(int), typeof(string))
    .WillFind(ProblemPrototype.Default)
    .Conclusive()
    .Verify();
    }

    [TestMethod]
    public void RuleShouldDetectLocalDirectConvertToString()
    {
    FxCopTest
    .ForRule<DoNotUseParseAndToStringToConvertTypes>()
    .OnMethod(
    @"
    public void TestMethod()
    {
    int i = Convert.ToInt32(1.ToString());
    }
    "
    )
    .WithReferencesTo(typeof(Convert), typeof(string))
    .WillFind(ProblemPrototype.Default)
    .Conclusive()
    .Verify();
    }

    [TestMethod]
    public void RuleShouldNotTriggerOnNormalConvert()
    {
    FxCopTest.ForRule<DoNotUseParseAndToStringToConvertTypes>().OnMethod(
    @"
    public void TestMethod()
    {
    int i = Convert.ToInt32(1f);
    }
    "
    )
    .WithReferencesTo(typeof(Convert), typeof(string))
    .WillNotFind(ProblemPrototype.Default)
    .Conclusive()
    .Verify();
    }

    [TestMethod]
    public void RuleShouldNotTriggerOnNormalParse()
    {
    FxCopTest
    .ForRule<DoNotUseParseAndToStringToConvertTypes>()
    .OnMethod(
    @"
    public void TestMethod()
    {
    int i = int.Parse(""1"");
    }
    "
    )
    .WithReferencesTo(typeof(Convert), typeof(string))
    .WillNotFind(ProblemPrototype.Default)
    .Conclusive()
    .Verify();
    }

    [TestMethod]
    public void RuleShouldNotTriggerOnNormalTryParse()
    {
    FxCopTest
    .ForRule<DoNotUseParseAndToStringToConvertTypes>()
    .OnMethod(
    @"
    public void TestMethod()
    {
    int i = -1;
    int.TryParse(""1"", out i);
    }
    "
    )
    .WithReferencesTo(typeof(Convert), typeof(string))
    .WillNotFind(ProblemPrototype.Default)
    .Conclusive()
    .Verify();
    }

    [TestMethod]
    public void RuleShouldDetectLocalDirectTryParseToString()
    {
    FxCopTest
    .ForRule<DoNotUseParseAndToStringToConvertTypes>()
    .OnMethod(
    @"
    public void TestMethod()
    {
    int i = -1;
    int.TryParse(1.ToString(), out i);
    }
    "
    )
    .WithReferencesTo(typeof(int), typeof(string))
    .WillFind(ProblemPrototype.Default)
    .Conclusive()
    .Verify();
    }
    }
    }