Skip to content

Instantly share code, notes, and snippets.

@jwieringa

jwieringa/gonum.md

Created May 6, 2019 18:53
Show Gist options

  • Select an option

    Learn more about clone URLs
  • Save jwieringa/67c78c85c43eac0c1685cdd8ff971d04 to your computer and use it in GitHub Desktop.

Select an option

Learn more about clone URLs
Save jwieringa/67c78c85c43eac0c1685cdd8ff971d04 to your computer and use it in GitHub Desktop.
Download ZIP

Revisions

  1. jwieringa revised this gist May 6, 2019. 1 changed file with 0 additions and 2 deletions.
    2 changes: 0 additions & 2 deletions gonum.md
    View file
    Original file line number Diff line number Diff line change
    @@ -1,7 +1,5 @@
    Working off from LDA project on https://github.com/RadiusNetworks/lda/pull/7

    This is what I think is the source of the problem. I could be wrong because `gonum` is also part of the processor project, but even if I'm wrong this still is going to need to be fixed on LDA.

    What I expect:
    + The `go get` command sets `gonum` version in `go.mod` to [gonum revision](https://github.com/gonum/gonum/commits/73ea1e732937f96d723d31dc5263d214a275d204)
    + Running the tests succeed
  2. jwieringa created this gist May 6, 2019.
    59 changes: 59 additions & 0 deletions gonum.md
    View file
    Original file line number Diff line number Diff line change
    @@ -0,0 +1,59 @@
    Working off from LDA project on https://github.com/RadiusNetworks/lda/pull/7

    This is what I think is the source of the problem. I could be wrong because `gonum` is also part of the processor project, but even if I'm wrong this still is going to need to be fixed on LDA.

    What I expect:
    + The `go get` command sets `gonum` version in `go.mod` to [gonum revision](https://github.com/gonum/gonum/commits/73ea1e732937f96d723d31dc5263d214a275d204)
    + Running the tests succeed

    What I observe:
    + The `@revision` of `go get` is ignored
    + The `latest` version is fetched setting the revision to the [last commit on master](https://github.com/gonum/gonum/commits/4a2eb0188cbc)
    + `go test` fails
    ```
    # github.com/RadiusNetworks/lda [github.com/RadiusNetworks/lda.test]
    ./lda.go:164:20: too many arguments in call to ld.eigen.Factorize
    have (*mat.Dense, bool, bool)
    want (mat.Matrix, mat.EigenKind)
    ```
    Obtained results by executing `go get`.
    ```bash
    $ go get gonum.org/v1/gonum@73ea1e732937f96d723d31dc5263d214a275d204
    go: finding gonum.org/v1/gonum latest
    ```
    Git diff after `go get`.
    ```diff
    diff --git a/go.mod b/go.mod
    index 3be6763..454fd54 100644
    --- a/go.mod
    +++ b/go.mod
    @@ -3,6 +3,11 @@ module github.com/RadiusNetworks/lda
    go 1.12

    require (
    - gonum.org/v1/gonum v0.0.0-20180816165407-929014505bf4
    - gonum.org/v1/plot v0.0.0-20190410204940-3a5f52653745
    + github.com/ajstarks/svgo v0.0.0-20180226025133-644b8db467af // indirect
    + github.com/fogleman/gg v1.2.1-0.20190220221249-0403632d5b90 // indirect
    + github.com/golang/freetype v0.0.0-20170609003504-e2365dfdc4a0 // indirect
    + github.com/jung-kurt/gofpdf v1.0.3-0.20190309125859-24315acbbda5 // indirect
    + golang.org/x/image v0.0.0-20180708004352-c73c2afc3b81 // indirect
    + gonum.org/v1/gonum v0.0.0-20190502212712-4a2eb0188cbc
    + rsc.io/pdf v0.1.1 // indirect
    )
    diff --git a/go.sum b/go.sum
    index 99fd0d0..01db5c5 100644
    --- a/go.sum
    +++ b/go.sum
    @@ -19,6 +19,8 @@ gonum.org/v1/gonum v0.0.0-20180816165407-929014505bf4 h1:nYxTaCPaVoJbxx+vMVnsFb6
    gonum.org/v1/gonum v0.0.0-20180816165407-929014505bf4/go.mod h1:Y+Yx5eoAFn32cQvJDxZx5Dpnq+c3wtXuadVZAcxbbBo=
    gonum.org/v1/gonum v0.0.0-20190430210020-9827ae2933ff h1:PSmLTFCI0KBBLcaxSbM8ejKR6f7XuDyQS3R8t72ailE=
    gonum.org/v1/gonum v0.0.0-20190430210020-9827ae2933ff/go.mod h1:2ltnJ7xHfj0zHS40VVPYEAAMTa3ZGguvHGBSJeRWqE0=
    +gonum.org/v1/gonum v0.0.0-20190502212712-4a2eb0188cbc h1:+c7TChc7Bi9WFPyWzDxu8mnEhA29YW/0NBDy4V24exU=
    +gonum.org/v1/gonum v0.0.0-20190502212712-4a2eb0188cbc/go.mod h1:2ltnJ7xHfj0zHS40VVPYEAAMTa3ZGguvHGBSJeRWqE0=
    gonum.org/v1/netlib v0.0.0-20190313105609-8cb42192e0e0/go.mod h1:wa6Ws7BG/ESfp6dHfk7C6KdzKA7wR7u/rKwOGE66zvw=
    gonum.org/v1/plot v0.0.0-20190410204940-3a5f52653745 h1:Xaq5xR1I2KM/MWp1vwZxOosUPa1U8wtNN8zRbVko0ZY=
    gonum.org/v1/plot v0.0.0-20190410204940-3a5f52653745/go.mod h1:Wt8AAjI+ypCyYX3nZBvf6cAIx93T+c/OS2HFAYskSZc=
    ```