Skip to content

Instantly share code, notes, and snippets.

@mahesh-krishnakumar

mahesh-krishnakumar/pf_merge_checklist.md

Last active November 12, 2020 10:30
Show Gist options
  • Save mahesh-krishnakumar/008c61fc5a11073e6c2848cb5037ff3a to your computer and use it in GitHub Desktop.
Save mahesh-krishnakumar/008c61fc5a11073e6c2848cb5037ff3a to your computer and use it in GitHub Desktop.
Download ZIP
Pupilfirst PR merge checklist
Raw
pf_merge_checklist.md
  • Added spec for the feature/bug.
  • Updated I18n files for relevant texts in UI
  • Updated developer and product docs if applicable
  • Check if new tables/columns added need to be handled in the following services: Users::DeleteAccountService, Courses::CloneService, Courses::DeleteService, Courses::DemoContentService, Schools::DeleteService
  • Check if changes in package components are published in npm
  • Added development seeds for new tables, if relevant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment