Skip to content

Instantly share code, notes, and snippets.

@maheshwarLigade

maheshwarLigade/AndroidJavaCodeReview.md

Forked from srivastavarobin/AndroidJavaCodeReview.md
Created December 24, 2015 03:01
Show Gist options

  • Select an option

    Learn more about clone URLs
  • Save maheshwarLigade/4779de83b868f59b730c to your computer and use it in GitHub Desktop.

Select an option

Learn more about clone URLs
Save maheshwarLigade/4779de83b868f59b730c to your computer and use it in GitHub Desktop.
Download ZIP

Revisions

  1. @srivastavarobin srivastavarobin revised this gist Feb 12, 2014. 1 changed file with 11 additions and 10 deletions.
    21 changes: 11 additions & 10 deletions AndroidJavaCodeReview.md
    View file
    Original file line number Diff line number Diff line change
    @@ -9,17 +9,18 @@
    8. Can it use already available Util functions?
    9. Does the large set of input for a function deserve a new bean to be created?
    10. Can we decrease the coupling?
    11. How will the functionalities affect the performance of the app - time and memory?
    12. Is it absolutely necessary to run it on UI therad or would a background thread suffice?
    13. Are all the fail points handled?
    14. Does it degrade gracefully in case of unknown failures?
    15. Are the app-doing level standards being followed?
    16. Is the correct form of storage being used and is memory available for storage?
    11. Are all the input arguments being validated?
    12. How will the functionalities affect the performance of the app - time and memory?
    13. Is it absolutely necessary to run it on UI therad or would a background thread suffice?
    14. Are all the fail points handled?
    15. Does it degrade gracefully in case of unknown failures?
    16. Are the app-doing level standards being followed?
    17. Is the correct form of storage being used and is memory available for storage?
    * Shared Preference
    * DB
    * SD Card
    * Internal Storage
    17. Are the operations thread safe?
    18. What pieces of the component can be executed in parallel?
    19. Are the layouts suitable for all the screen dimensions?
    20. What classes would become obsolete after this implementation?
    18. Are the operations thread safe?
    19. What pieces of the component can be executed in parallel?
    20. Are the layouts suitable for all the screen dimensions?
    21. What classes would become obsolete after this implementation?
  2. @srivastavarobin srivastavarobin revised this gist Feb 12, 2014. 1 changed file with 1 addition and 1 deletion.
    2 changes: 1 addition & 1 deletion AndroidJavaCodeReview.md
    View file
    Original file line number Diff line number Diff line change
    @@ -1,4 +1,4 @@
    # Code Review
    # My Android Java Code Review Checklist
    1. Is the functionality correct?
    2. Are the classes named suitably?
    3. Are the functions named suitably?
  3. @srivastavarobin srivastavarobin revised this gist Feb 12, 2014. 1 changed file with 3 additions and 2 deletions.
    5 changes: 3 additions & 2 deletions AndroidJavaCodeReview.md
    View file
    Original file line number Diff line number Diff line change
    @@ -20,5 +20,6 @@
    * SD Card
    * Internal Storage
    17. Are the operations thread safe?
    18. Are the layouts suitable for all the screen dimensions?
    19. What classes would become obsolete after this implementation?
    18. What pieces of the component can be executed in parallel?
    19. Are the layouts suitable for all the screen dimensions?
    20. What classes would become obsolete after this implementation?
  4. @srivastavarobin srivastavarobin revised this gist Feb 12, 2014. 1 changed file with 4 additions and 4 deletions.
    8 changes: 4 additions & 4 deletions AndroidJavaCodeReview.md
    View file
    Original file line number Diff line number Diff line change
    @@ -15,10 +15,10 @@
    14. Does it degrade gracefully in case of unknown failures?
    15. Are the app-doing level standards being followed?
    16. Is the correct form of storage being used and is memory available for storage?
    a. Shared Preference
    b. DB
    c. SD Card
    d. Internal Storage
    * Shared Preference
    * DB
    * SD Card
    * Internal Storage
    17. Are the operations thread safe?
    18. Are the layouts suitable for all the screen dimensions?
    19. What classes would become obsolete after this implementation?
  5. @srivastavarobin srivastavarobin revised this gist Feb 12, 2014. 1 changed file with 5 additions and 5 deletions.
    10 changes: 5 additions & 5 deletions AndroidJavaCodeReview.md
    View file
    Original file line number Diff line number Diff line change
    @@ -2,7 +2,7 @@
    1. Is the functionality correct?
    2. Are the classes named suitably?
    3. Are the functions named suitably?
    4. How's the datastructure being used? Is the correct DS or it needs improvement
    4. How's the datastructure being used? Is it the correct DS or it needs improvement?
    5. Can the classes be further borken into small classes?
    6. Do we need an interface?
    7. If it contain functions that can be reused later then are there Utils created for them?
    @@ -15,10 +15,10 @@
    14. Does it degrade gracefully in case of unknown failures?
    15. Are the app-doing level standards being followed?
    16. Is the correct form of storage being used and is memory available for storage?
    1. Shared Preference
    2. DB
    3. SD Card
    4. Internal Storage
    a. Shared Preference
    b. DB
    c. SD Card
    d. Internal Storage
    17. Are the operations thread safe?
    18. Are the layouts suitable for all the screen dimensions?
    19. What classes would become obsolete after this implementation?
  6. @srivastavarobin srivastavarobin revised this gist Feb 12, 2014. 1 changed file with 4 additions and 4 deletions.
    8 changes: 4 additions & 4 deletions AndroidJavaCodeReview.md
    View file
    Original file line number Diff line number Diff line change
    @@ -15,10 +15,10 @@
    14. Does it degrade gracefully in case of unknown failures?
    15. Are the app-doing level standards being followed?
    16. Is the correct form of storage being used and is memory available for storage?
    16.1 Shared Preference
    16.2 DB
    16.3 SD Card
    16.4 Internal Storage
    1. Shared Preference
    2. DB
    3. SD Card
    4. Internal Storage
    17. Are the operations thread safe?
    18. Are the layouts suitable for all the screen dimensions?
    19. What classes would become obsolete after this implementation?
  7. @srivastavarobin srivastavarobin revised this gist Feb 12, 2014. 1 changed file with 18 additions and 1 deletion.
    19 changes: 18 additions & 1 deletion AndroidJavaCodeReview.md
    View file
    Original file line number Diff line number Diff line change
    @@ -4,4 +4,21 @@
    3. Are the functions named suitably?
    4. How's the datastructure being used? Is the correct DS or it needs improvement
    5. Can the classes be further borken into small classes?
    6. Does the large set of input for a function deserve a new bean to be created?
    6. Do we need an interface?
    7. If it contain functions that can be reused later then are there Utils created for them?
    8. Can it use already available Util functions?
    9. Does the large set of input for a function deserve a new bean to be created?
    10. Can we decrease the coupling?
    11. How will the functionalities affect the performance of the app - time and memory?
    12. Is it absolutely necessary to run it on UI therad or would a background thread suffice?
    13. Are all the fail points handled?
    14. Does it degrade gracefully in case of unknown failures?
    15. Are the app-doing level standards being followed?
    16. Is the correct form of storage being used and is memory available for storage?
    16.1 Shared Preference
    16.2 DB
    16.3 SD Card
    16.4 Internal Storage
    17. Are the operations thread safe?
    18. Are the layouts suitable for all the screen dimensions?
    19. What classes would become obsolete after this implementation?
  8. @srivastavarobin srivastavarobin revised this gist Feb 12, 2014. 1 changed file with 4 additions and 1 deletion.
    5 changes: 4 additions & 1 deletion AndroidJavaCodeReview.md
    View file
    Original file line number Diff line number Diff line change
    @@ -1,4 +1,7 @@
    # Code Review
    1. Is the functionality correct?
    2. Are the classes named suitably?
    3.
    3. Are the functions named suitably?
    4. How's the datastructure being used? Is the correct DS or it needs improvement
    5. Can the classes be further borken into small classes?
    6. Does the large set of input for a function deserve a new bean to be created?
  9. @srivastavarobin srivastavarobin renamed this gist Feb 12, 2014. 1 changed file with 0 additions and 0 deletions.
    0 AndroidJavaCodeReview → AndroidJavaCodeReview.md
    View file
    File renamed without changes.
  10. @srivastavarobin srivastavarobin created this gist Feb 12, 2014.
    4 changes: 4 additions & 0 deletions AndroidJavaCodeReview
    View file
    Original file line number Diff line number Diff line change
    @@ -0,0 +1,4 @@
    # Code Review
    1. Is the functionality correct?
    2. Are the classes named suitably?
    3.