Last active
July 9, 2019 12:44
-
-
Save mkingori/ea0136957fce414742e48a40fede0ede to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| package main | |
| import ( | |
| "fmt" | |
| "log" | |
| "time" | |
| ) | |
| var ( | |
| maxPoolQueue = 100 | |
| maxPoolWorker = 3 | |
| ) | |
| // Pool holds the params for the worker pool | |
| type Pool struct { | |
| // WG *sync.WaitGroup | |
| Jobs chan int | |
| Results chan int | |
| Errors chan error | |
| } | |
| // NewPool initializes the worker pool | |
| func NewPool() *Pool { | |
| return &Pool{ | |
| // WG: &sync.WaitGroup{}, | |
| Jobs: make(chan int, maxPoolQueue), | |
| Results: make(chan int, maxPoolQueue), | |
| Errors: make(chan error, maxPoolQueue), | |
| } | |
| } | |
| // Run runs the worker pool | |
| func (p *Pool) Run() error { | |
| for w := 1; w <= maxPoolWorker; w++ { | |
| go p.worker(w) | |
| } | |
| for j := 1; j <= maxPoolQueue; j++ { | |
| p.Jobs <- j | |
| // p.WG.Add(1) | |
| } | |
| close(p.Jobs) | |
| for a := 1; a <= maxPoolQueue; a++ { | |
| select { | |
| case err := <-p.Errors: | |
| return err | |
| default: | |
| fmt.Println(<-p.Results) | |
| // p.WG.Done() | |
| } | |
| } | |
| // p.WG.Wait() | |
| return nil | |
| } | |
| func (p *Pool) worker(id int) { | |
| for j := range p.Jobs { | |
| fmt.Println("Worker", id, "processing job", j) | |
| // Simulation of error to be returned | |
| if j == 20 { | |
| p.Errors <- fmt.Errorf("Error occured on job %d", j) | |
| continue | |
| } | |
| p.Results <- j * 2 | |
| time.Sleep(time.Second) | |
| } | |
| } | |
| func main() { | |
| p := NewPool() | |
| if err := p.Run(); err != nil { | |
| log.Fatal(err) | |
| } | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I hold an opposing view on this matter. To me the less code you use to implement a feature is directly proportional to how readable the code is. Also other implementations could make your code more readable but slower, so its often recommended that you evaluate all the choices at hand.