mohit ojha mohitrgiit

What should we look for when doing code review? How should we receive code reviews from others?

thoughbot's Code Review guide is a great starting point. It articulates principles for the relational side of code review. This is especially relevant for us in a remote environment. How we give and receive feedback is as important as the feedback itself.

The following is a very incomplete list of questions to ask yourself during code review. The items here are meant to be starting points for a conversation with the code's author. Always assume the best intentions.

The purpose of design is to allow you to do design later, and it's primary goal is to reduce the cost of change.

SOLID Design:

• Single Responsibility Principle: a class should have only a single responsibility
• Open-Closed Principle: Software entities should be open for extension, but closed for modification (inherit instead of modifying existing classes).
• Liskov Substitution: Objects in a program should be replaceable with instances of their subtypes without altering the correctness of that program.
• Interface Segregation: Many client-specific interfaces are better than one general-purpose interface.