mosdevly · July 18, 2019 14:22 · Jul 18, 2019 · Jul 18, 2019 · Jul 18, 2019 · Jul 18, 2019
diff --git a/solid_bad.py b/solid_bad.py
@@ -0,0 +1,17 @@
+"""Open/Closed Principle
+Example inspired by this wonderful piece here: http://joelabrahamsson.com/a-simple-example-of-the-openclosed-principle/
+"""
+
+# Area calculator: calculate area of a rectangle
+class Rectangle:
+    def __init__(self, width, height):
+        self.width = width
+        self.height = height
+
+    def area(self):
+        return self.width * self.height
+
+# Calculate area of multiple rectangles  
+
+class AreaCalculator:
+
diff --git a/solid_good.py b/solid_good.py
@@ -39,3 +39,6 @@ def __init__(self, radius):
     def area(self):
         import math
         return (self.radius**2)*math.pi
+class AreaCalculator:
+    def calculate(self, shapes):
+
diff --git a/solid.py b/solid.py
@@ -1,15 +0,0 @@
-"""
-Single Responsibility Principle
-
-Every module, class, or function should have responsibility over a single part 
-of the functionality provided by the software.
-
-User class handles one thing: the identity of a user. It's sole method does exactly 1 thing: changes the name property.
-"""
-class User:
-    id = 1;
-    name = '';
-
-    def updateName(newName):
-        this.name = newName
-        console.log('Name updated.')

diff --git a/solid_good.py b/solid_good.py
@@ -0,0 +1,41 @@
+"""
+Single Responsibility Principle
+
+Every module, class, or function should have responsibility over a single part 
+of the functionality provided by the software.
+
+User class handles one thing: the identity of a user. It's sole method does exactly 1 thing: changes the name property.
+"""
+class User:
+    id = 1;
+    name = '';
+
+    def updateName(newName):
+        this.name = newName
+        console.log('Name updated.')
+
+
+"""Open/Closed Principle
+Example inspired by this wonderful piece here: http://joelabrahamsson.com/a-simple-example-of-the-openclosed-principle/
+"""
+class Shape:
+    def area(self):
+        NotImplementedError('You must implement this method!')
+
+
+class Rectangle(Shape):
+    def __init__(self, width, height):
+        self.width = width
+        self.height = height
+
+    def area(self):
+        return self.width * self.height
+
+
+class Circle(Shape):
+    def __init__(self, radius):
+        self.radius = radius
+
+    def area(self):
+        import math
+        return (self.radius**2)*math.pi
diff --git a/solid.js b/solid.js
@@ -1,16 +0,0 @@
-/**
- * Single Responsibilit Principle
- * @desc every module, class, or function should have responsibility over a single part 
- * of the functionality provided by the software.
- * 
- * User class handles one thing: the identity of a user. It's sole method does exactly 1 thing: changes the name property.
- */
-class User {
-  id = 1;
-  name = '';
-
-  updateName(newName) {
-    this.name = newName
-    console.log('Name updated.')
-  }
-{

diff --git a/solid.py b/solid.py
@@ -0,0 +1,15 @@
+"""
+Single Responsibility Principle
+
+Every module, class, or function should have responsibility over a single part 
+of the functionality provided by the software.
+
+User class handles one thing: the identity of a user. It's sole method does exactly 1 thing: changes the name property.
+"""
+class User:
+    id = 1;
+    name = '';
+
+    def updateName(newName):
+        this.name = newName
+        console.log('Name updated.')
diff --git a/solid.js b/solid.js
@@ -3,9 +3,9 @@
  * @desc every module, class, or function should have responsibility over a single part 
  * of the functionality provided by the software.
  * 
- * Person class handles one thing: the identity of a person. It's sole method does exactly 1 thing: changes the name property.
+ * User class handles one thing: the identity of a user. It's sole method does exactly 1 thing: changes the name property.
  */
-class Person {
+class User {
   id = 1;
   name = '';
 

diff --git a/solid.js b/solid.js
@@ -1,4 +1,12 @@
+/**
+ * Single Responsibilit Principle
+ * @desc every module, class, or function should have responsibility over a single part 
+ * of the functionality provided by the software.
+ * 
+ * Person class handles one thing: the identity of a person. It's sole method does exactly 1 thing: changes the name property.
+ */
 class Person {
+  id = 1;
   name = '';
 
   updateName(newName) {

diff --git a/solid.js b/solid.js
@@ -0,0 +1,8 @@
+class Person {
+  name = '';
+
+  updateName(newName) {
+    this.name = newName
+    console.log('Name updated.')
+  }
+{
No results found