Skip to content

Instantly share code, notes, and snippets.

@pamolloy
Last active February 26, 2019 15:28
Show Gist options
  • Save pamolloy/d9ba1fc2b0a6cfa6fbd66798cd2389ac to your computer and use it in GitHub Desktop.
Save pamolloy/d9ba1fc2b0a6cfa6fbd66798cd2389ac to your computer and use it in GitHub Desktop.

Revisions

  1. pamolloy revised this gist Feb 22, 2019. 1 changed file with 1 addition and 1 deletion.
    2 changes: 1 addition & 1 deletion README.md
    Original file line number Diff line number Diff line change
    @@ -1,4 +1,4 @@
    Selecting `CONFIG_SYS_I2C_ZYNQ` and `CONFIG_ZYNQ_I2C0` builds successfully (see [Xilinx documentation](https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18842029/U-Boot+I2C+Driver#U-BootI2CDriver-ForZynqMP)).
    Selecting `CONFIG_SYS_I2C_ZYNQ` and `CONFIG_ZYNQ_I2C0` builds successfully (see [Xilinx documentation](https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18842029/U-Boot+I2C+Driver#U-BootI2CDriver-ForZynqMP)). But those are old config options and should be replaced with `CONFIG_I2C_CADENCE`.

    Selecting `CONFIG_ENV_IS_IN_EEPROM` causes the following assertion to fail:

  2. pamolloy revised this gist Feb 22, 2019. 1 changed file with 1 addition and 1 deletion.
    2 changes: 1 addition & 1 deletion README.md
    Original file line number Diff line number Diff line change
    @@ -31,7 +31,7 @@ drivers/built-in.o: In function `i2c_eeprom_std_read':
    /home/philip/repos/third-party/buildroot/output/build/uboot-custom/drivers/misc/i2c_eeprom.c:35: undefined reference to `dm_i2c_read'
    ```

    Selecting `CONFIG_DM_I2C` in menuconfig results in the following compiler error:
    Selecting `CONFIG_DM_I2C`, despite being deprected, results in the following compiler error:

    ```
    In file included from include/config.h:8,
  3. pamolloy revised this gist Feb 22, 2019. 1 changed file with 1 addition and 1 deletion.
    2 changes: 1 addition & 1 deletion README.md
    Original file line number Diff line number Diff line change
    @@ -1,4 +1,4 @@
    Selecting `CONFIG_SYS_I2C_ZYNQ` and `CONFIG_ZYNQ_I2C0` build successfully (see [Xilinx documentation](https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18842029/U-Boot+I2C+Driver#U-BootI2CDriver-ForZynqMP)).
    Selecting `CONFIG_SYS_I2C_ZYNQ` and `CONFIG_ZYNQ_I2C0` builds successfully (see [Xilinx documentation](https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18842029/U-Boot+I2C+Driver#U-BootI2CDriver-ForZynqMP)).

    Selecting `CONFIG_ENV_IS_IN_EEPROM` causes the following assertion to fail:

  4. pamolloy created this gist Feb 22, 2019.
    44 changes: 44 additions & 0 deletions README.md
    Original file line number Diff line number Diff line change
    @@ -0,0 +1,44 @@
    Selecting `CONFIG_SYS_I2C_ZYNQ` and `CONFIG_ZYNQ_I2C0` build successfully (see [Xilinx documentation](https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18842029/U-Boot+I2C+Driver#U-BootI2CDriver-ForZynqMP)).

    Selecting `CONFIG_ENV_IS_IN_EEPROM` causes the following assertion to fail:

    ```
    cmd/eeprom.c:58:2: error: #error CONFIG_SYS_I2C_EEPROM_ADDR_LEN must be 1 or 2
    #error CONFIG_SYS_I2C_EEPROM_ADDR_LEN must be 1 or 2
    ^~~~~
    ...
    ```

    Selecting `CONFIG_I2C_EEPROM` and configuring it causes the following causes the following compiler errors:

    ```
    cmd/eeprom.c:68:1: error: expected identifier or '(' before '{' token
    {
    ^
    In file included from cmd/eeprom.c:22:
    include/common.h:282:54: error: expected identifier or '(' before 'void'
    #define eeprom_read(dev_addr, offset, buffer, cnt) ((void)-ENOSYS)
    ^~~~
    ...
    ```

    Selecting `CONFIG_CMD_EEPROM`, despite being deprecated, causes tons of compiler errors:

    ```
    drivers/built-in.o: In function `i2c_eeprom_std_read':
    /home/philip/repos/third-party/buildroot/output/build/uboot-custom/drivers/misc/i2c_eeprom.c:35: undefined reference to `dm_i2c_read'
    ```

    Selecting `CONFIG_DM_I2C` in menuconfig results in the following compiler error:

    ```
    In file included from include/config.h:8,
    from ./include/common.h:17:
    include/config_fallbacks.h:51:4: error: #error "Cannot define CONFIG_SYS_I2C when CONFIG_DM_I2C is used"
    # error "Cannot define CONFIG_SYS_I2C when CONFIG_DM_I2C is used"
    ^~~~~
    ...
    ```