timm-oh · December 17, 2023 21:04 · Jun 4, 2020 · May 15, 2020 · May 15, 2020 · Dec 8, 2019
diff --git a/application_helper.rb b/application_helper.rb
@@ -1,7 +1,7 @@
 # app/helpers/application_helper.rb
 module ApplicationHelper
   # active_storage_item could be a blob or variant object
-  def proxy_url(active_storage_item, options)
+  def proxy_url(active_storage_item, options = {})
     options.merge!(host: ENV['ASSETS_HOST']) if ENV['ASSETS_HOST'].present?
 
     # proxy: 'true' allows you to stil have the original functionality while

diff --git a/application_helper.rb b/application_helper.rb
@@ -9,7 +9,7 @@ def proxy_url(active_storage_item, options)
     # forwards this param otherwise active storage will always do the default
     # behavior which is a redirect to the service.
     # This is also meant to be intended for items that are always going to be
-    # public. If you have files that might be private then theres no point in
+    # public. If you have files that might be private then there's no point in
     # caching it with cloudfront.
     # See lib/core_extensions/active_storage/blob/downloader and
     # lib/core_extensions/active_storage/representation/downloader

diff --git a/readme.md b/readme.md
@@ -14,5 +14,5 @@ proxy_url(foo.image)
 # https://thing.cloudfront.net/rails/active_storage/representations/etc..etc
 proxy_url(foo.image.variant(resize: '100x100'))
 ```
-This is nowhere perfect. Just gets the job done in a simple manner.
+This is nowhere near perfect. Just gets the job done in a simple manner.
 Inspiration from `https://github.com/rails/rails/pull/34477`
diff --git a/readme.md b/readme.md
@@ -14,4 +14,5 @@ proxy_url(foo.image)
 # https://thing.cloudfront.net/rails/active_storage/representations/etc..etc
 proxy_url(foo.image.variant(resize: '100x100'))
 ```
-This is nowhere perfect. Just gets the job done in a simple manner.
+This is nowhere perfect. Just gets the job done in a simple manner.
+Inspiration from `https://github.com/rails/rails/pull/34477`
diff --git a/readme.md b/readme.md
@@ -1,7 +1,5 @@
 ### Basic Usage
 
-Ensure that you have setup cloudfront similar to this `https://ricostacruz.com/til/rails-and-cloudfront`
-
 ```ruby
 # ENV["ASSETS_HOST"] = 'thing.cloudfront.net'
 class Foo < ApplicationRecord

diff --git a/application_helper.rb b/application_helper.rb
@@ -1,5 +1,6 @@
 # app/helpers/application_helper.rb
 module ApplicationHelper
+  # active_storage_item could be a blob or variant object
   def proxy_url(active_storage_item, options)
     options.merge!(host: ENV['ASSETS_HOST']) if ENV['ASSETS_HOST'].present?
 

diff --git a/readme.md b/readme.md
@@ -16,3 +16,4 @@ proxy_url(foo.image)
 # https://thing.cloudfront.net/rails/active_storage/representations/etc..etc
 proxy_url(foo.image.variant(resize: '100x100'))
 ```
+This is nowhere perfect. Just gets the job done in a simple manner.
diff --git a/application_helper.rb b/application_helper.rb
@@ -5,8 +5,11 @@ def proxy_url(active_storage_item, options)
 
     # proxy: 'true' allows you to stil have the original functionality while
     # being able to proxy through a CDN. You've got to ensure that your CDN
-    # forwards this param otherwise it will always do the default
-    # behavior which is a redirect.
+    # forwards this param otherwise active storage will always do the default
+    # behavior which is a redirect to the service.
+    # This is also meant to be intended for items that are always going to be
+    # public. If you have files that might be private then theres no point in
+    # caching it with cloudfront.
     # See lib/core_extensions/active_storage/blob/downloader and
     # lib/core_extensions/active_storage/representation/downloader
     polymorphic_url(active_storage_item, options.merge(proxy: 'true'))

diff --git a/blob_downloader.rb b/blob_downloader.rb
@@ -1,4 +1,5 @@
 # lib/core_extensions/active_storage/blob/downloader.rb
+# had to make the file a different name because reasons ¯\_(ツ)_/¯
 module CoreExtensions
   module ActiveStorage
     module Blob

diff --git a/representation_downloader.rb b/representation_downloader.rb
@@ -1,4 +1,5 @@
 # lib/core_extensions/active_storage/representation/downloader.rb
+# had to make the file a different name because reasons ¯\_(ツ)_/¯
 module CoreExtensions
   module ActiveStorage
     module Representation

diff --git a/readme.md b/readme.md
@@ -0,0 +1,18 @@
+### Basic Usage
+
+Ensure that you have setup cloudfront similar to this `https://ricostacruz.com/til/rails-and-cloudfront`
+
+```ruby
+# ENV["ASSETS_HOST"] = 'thing.cloudfront.net'
+class Foo < ApplicationRecord
+  has_one_attached :thing
+end
+
+foo = Foo.first
+
+# https://thing.cloudfront.net/rails/active_storage/blobs/etc..etc
+proxy_url(foo.image)
+
+# https://thing.cloudfront.net/rails/active_storage/representations/etc..etc
+proxy_url(foo.image.variant(resize: '100x100'))
+```
diff --git a/application_helper.rb b/application_helper.rb
@@ -0,0 +1,14 @@
+# app/helpers/application_helper.rb
+module ApplicationHelper
+  def proxy_url(active_storage_item, options)
+    options.merge!(host: ENV['ASSETS_HOST']) if ENV['ASSETS_HOST'].present?
+
+    # proxy: 'true' allows you to stil have the original functionality while
+    # being able to proxy through a CDN. You've got to ensure that your CDN
+    # forwards this param otherwise it will always do the default
+    # behavior which is a redirect.
+    # See lib/core_extensions/active_storage/blob/downloader and
+    # lib/core_extensions/active_storage/representation/downloader
+    polymorphic_url(active_storage_item, options.merge(proxy: 'true'))
+  end
+end
diff --git a/blob_downloader.rb b/blob_downloader.rb
@@ -0,0 +1,20 @@
+# lib/core_extensions/active_storage/blob/downloader.rb
+module CoreExtensions
+  module ActiveStorage
+    module Blob
+      module Downloader
+        include CoreExtensions::ActiveStorage::Headers
+
+        def show
+          return super unless params[:proxy] == 'true'
+          set_headers(@blob)
+          @blob.download do |chunk|
+            response.stream.write(chunk)
+          end
+        ensure
+          response.stream.close
+        end
+      end
+    end
+  end
+end
diff --git a/core_extentions.rb b/core_extentions.rb
@@ -0,0 +1,6 @@
+# config/initializers/core_extentions.rb
+Dir[File.expand_path(File.join(File.dirname(File.absolute_path(__FILE__)), 'lib/core_extensions')) + "/**/*.rb"].each do |file|
+  require file
+end
+ActiveStorage::RepresentationsController.prepend CoreExtensions::ActiveStorage::Representation::Downloader
+ActiveStorage::BlobsController.prepend CoreExtensions::ActiveStorage::Blob::Downloader
diff --git a/headers.rb b/headers.rb
@@ -0,0 +1,22 @@
+# lib/core_extensions/active_storage/headers.rb
+module CoreExtensions
+  module ActiveStorage
+    module Headers
+      extend ActiveSupport::Concern
+
+      private
+
+        def set_headers(blob)
+          # Hard coded this to 365, simply because thats what I want tbh
+          expires_in 365.days, public: true
+
+          response.headers["Content-Type"] = blob.content_type
+          # Commented this out because in Rails 5.2.3 this isn't a thing
+          # response.headers["Content-Disposition"] = ActionDispatch::Http::ContentDisposition.format(
+          #   disposition: params[:disposition] || "inline",
+          #   filename: blob.filename.sanitized
+          # )
+        end
+    end
+  end
+end
diff --git a/representation_downloader.rb b/representation_downloader.rb
@@ -0,0 +1,21 @@
+# lib/core_extensions/active_storage/representation/downloader.rb
+module CoreExtensions
+  module ActiveStorage
+    module Representation
+      module Downloader
+        include CoreExtensions::ActiveStorage::Headers
+
+        def show
+          return super unless params[:proxy] == 'true'
+          set_headers(@blob)
+          variant = @blob.representation(params[:variation_key]).processed
+          @blob.service.download(variant.key) do |chunk|
+            response.stream.write(chunk)
+          end
+        ensure
+          response.stream.close
+        end
+      end
+    end
+  end
+end
No results found