Last active
August 11, 2022 11:10
-
-
Save tinfoil-knight/49dcf7a5182472129f9a119fab9de79f to your computer and use it in GitHub Desktop.
Revisions
-
tinfoil-knight revised this gist
Aug 11, 2022 . 1 changed file with 4 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,5 +1,9 @@ # OSS Log ## [fix: stop pass through request params for function redirects](https://github.com/netlify/cli/pull/4897) - I've actually started using a debugger now which helped a lot in finding this bug - vscode has a separate JS debug terminal that'll listen to any NodeJS process that you run ## [feat(command-deploy): allow support for deploying by site name #4327](https://github.com/netlify/cli/pull/4327) - wrote tests, doc and code for this one - the cli repo is great at keeping documentation near code so it can be updated alongside code changes. it was pretty easy to add support for a different argument type -
tinfoil-knight revised this gist
Feb 27, 2022 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,6 +1,6 @@ # OSS Log ## [feat(command-deploy): allow support for deploying by site name #4327](https://github.com/netlify/cli/pull/4327) - wrote tests, doc and code for this one - the cli repo is great at keeping documentation near code so it can be updated alongside code changes. it was pretty easy to add support for a different argument type - should've asked a few questions before the PR to avoid assuming that site ids are uuidv4 when there was a solution that could work without assuming anything about what the backend stores ids as -
tinfoil-knight revised this gist
Feb 27, 2022 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,7 +1,7 @@ # OSS Log ## [](https://github.com/netlify/cli/pull/4327) - wrote tests, doc and code for this one - the cli repo is great at keeping documentation near code so it can be updated alongside code changes. it was pretty easy to add support for a different argument type - should've asked a few questions before the PR to avoid assuming that site ids are uuidv4 when there was a solution that could work without assuming anything about what the backend stores ids as - fixes 2 issues at once -
tinfoil-knight revised this gist
Feb 27, 2022 . 1 changed file with 6 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,5 +1,11 @@ # OSS Log ## [](https://github.com/netlify/cli/pull/4327) - wrote tests, doc and changed code for this one - the cli repo is great at keeping documentation near code so it can be updated alongside code changes. it was pretty easy to add support for a different argument type - should've asked a few questions before the PR to avoid assuming that site ids are uuidv4 when there was a solution that could work without assuming anything about what the backend stores ids as - fixes 2 issues at once ## [fix: make site suggestion flow consistent #4185](https://github.com/netlify/cli/pull/4185) - single word fix -
tinfoil-knight revised this gist
Feb 27, 2022 . 1 changed file with 1 addition and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,6 +1,7 @@ # OSS Log ## [fix: make site suggestion flow consistent #4185](https://github.com/netlify/cli/pull/4185) - single word fix ## [fix: external redirects not being matched correctly closes #3770](https://github.com/netlify/cli/pull/4109) - flaky tests make life miserable. this PR had tests failing on different OSes but not all of them at once. I don't like these sort of platform bugs -
tinfoil-knight revised this gist
Feb 27, 2022 . 1 changed file with 2 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,5 +1,7 @@ # OSS Log ## [fix: make site suggestion flow consistent #4185](https://github.com/netlify/cli/pull/4185) ## [fix: external redirects not being matched correctly closes #3770](https://github.com/netlify/cli/pull/4109) - flaky tests make life miserable. this PR had tests failing on different OSes but not all of them at once. I don't like these sort of platform bugs - first pr for which I wrote a test, makes me happy to know that no one will break it unknowingly -
tinfoil-knight revised this gist
Feb 4, 2022 . 1 changed file with 5 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,5 +1,10 @@ # OSS Log ## [fix: external redirects not being matched correctly closes #3770](https://github.com/netlify/cli/pull/4109) - flaky tests make life miserable. this PR had tests failing on different OSes but not all of them at once. I don't like these sort of platform bugs - first pr for which I wrote a test, makes me happy to know that no one will break it unknowingly - debugging this was just a lot of print statements in a lot of places, I still haven't used a debugger with NodeJS, tried to use it with this one but wasn't able to get it running properly ## [feat(command-dev): add support for functionsPort flag fixes #3980](https://github.com/netlify/cli/pull/4048) - this was pretty low effort and turned out to be more of docs issue rather than a feature issue - codebases get big sometime and you don't even know if a particular feature is supported or not, maintaining updated documentation is very important -
tinfoil-knight revised this gist
Jan 21, 2022 . 1 changed file with 4 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,5 +1,9 @@ # OSS Log ## [feat(command-dev): add support for functionsPort flag fixes #3980](https://github.com/netlify/cli/pull/4048) - this was pretty low effort and turned out to be more of docs issue rather than a feature issue - codebases get big sometime and you don't even know if a particular feature is supported or not, maintaining updated documentation is very important ## [chore: replace deprecated querystring package with URLSearchParams API closes](https://github.com/netlify/cli/pull/3569) - be a bit more patient with what you claim to be true, always double-check, mistakes will forever be out there in the public forum -
tinfoil-knight revised this gist
Nov 5, 2021 . 1 changed file with 3 additions and 2 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -3,9 +3,10 @@ ## [chore: replace deprecated querystring package with URLSearchParams API closes](https://github.com/netlify/cli/pull/3569) - be a bit more patient with what you claim to be true, always double-check, mistakes will forever be out there in the public forum - there's a `deprecated` tag in JSDoc that can be used to mark things that are outdated - I tried to test my changes for this PR but gave up after some point and had to take things out and manually test them outside the repo (sad day), still not sure if everything is going to work, fortunately there are 3 folks tagged on this PR for review - edit: so it turns out I broke stuff: https://github.com/netlify/cli/issues/3588 - learning: don't work on features/tests you can't write the tests to or just ask for some help ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) @@ -38,7 +39,7 @@ - maintainers have other work too (I'm holding the urge to @ people constantly in my PRs) - decided to read up more about the [oclif](https://github.com/oclif/oclif) cli framework that the repo uses - `npm link` to use the repo cli directly (through symlinks) instead of doing a global install - edit: I made an typo in this one and fixed it after a few months in [#3563](https://github.com/netlify/cli/pull/3563), definitely need to be more responsible ## [refactor: enable and fix fp/no-loops](https://github.com/netlify/cli/pull/2852) -
tinfoil-knight revised this gist
Nov 4, 2021 . 1 changed file with 1 addition and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -5,6 +5,7 @@ - be a bit more patient with what you claim to be true, always double-check, mistakes will forever be out there in the public forum - there's a deprecated tag in JSDoc that can be used to mark things that are outdated - I tried to test my changes for this PR but gave up after some point and had to take things out and manually test them outside the repo (sad day), still not sure if everything is going to work, fortunately there are 3 folks tagged on this PR for review - edit: so it turns out I broke stuff: https://github.com/netlify/cli/issues/3588 ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) -
tinfoil-knight revised this gist
Nov 3, 2021 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -2,7 +2,7 @@ ## [chore: replace deprecated querystring package with URLSearchParams API closes](https://github.com/netlify/cli/pull/3569) - be a bit more patient with what you claim to be true, always double-check, mistakes will forever be out there in the public forum - there's a deprecated tag in JSDoc that can be used to mark things that are outdated - I tried to test my changes for this PR but gave up after some point and had to take things out and manually test them outside the repo (sad day), still not sure if everything is going to work, fortunately there are 3 folks tagged on this PR for review -
tinfoil-knight revised this gist
Nov 3, 2021 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -4,7 +4,7 @@ - be a bit more patient with what you claim, always double-check, mistakes will forever be out there in the public forum - there's a deprecated tag in JSDoc that can be used to mark things that are outdated - I tried to test my changes for this PR but gave up after some point and had to take things out and manually test them outside the repo (sad day), still not sure if everything is going to work, fortunately there are 3 folks tagged on this PR for review ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) -
tinfoil-knight revised this gist
Nov 3, 2021 . 1 changed file with 2 additions and 2 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -4,7 +4,7 @@ - be a bit more patient with what you claim, always double-check, mistakes will forever be out there in the public forum - there's a deprecated tag in JSDoc that can be used to mark things that are outdated - I tried to test my changes for this PR but gave up after some point and had to take things out and manually test them outside the repo, still not sure if everything is going to work, fortunately there are 3 folks tagged on this PR for review (sad day) ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) @@ -37,7 +37,7 @@ - maintainers have other work too (I'm holding the urge to @ people constantly in my PRs) - decided to read up more about the [oclif](https://github.com/oclif/oclif) cli framework that the repo uses - `npm link` to use the repo cli directly (through symlinks) instead of doing a global install - I made an typo in this one and fixed it after a few months in [#3563](https://github.com/netlify/cli/pull/3563), definitely need to be more responsible ## [refactor: enable and fix fp/no-loops](https://github.com/netlify/cli/pull/2852) -
tinfoil-knight revised this gist
Nov 3, 2021 . 1 changed file with 11 additions and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,37 +1,46 @@ # OSS Log ## [chore: replace deprecated querystring package with URLSearchParams API closes](https://github.com/netlify/cli/pull/3569) - be a bit more patient with what you claim, always double-check, mistakes will forever be out there in the public forum - there's a deprecated tag in JSDoc that can be used to mark things that are outdated - I tried to test my changes for this PR but gave up after some point and had to take things out and manually test them outside the repo, still not sure if everything is going to work, fortunately there are 3 folks tagged on this PR for review ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) - sometimes you can avoid using a mock by making a wrapper and only testing the responses from the core function's response instead of checking if the wrapping function throws an error, exits the process etc. ## [refactor: remove unused function detectAwsSdkError](https://github.com/netlify/cli/pull/3383) - don't just remove dead code without asking the original author - don't club changes you find while working on a PR, always create a separate PR for unrelated changes ## [refactor: warn, exit and error utils from oclif command class](https://github.com/netlify/cli/pull/3028) - `switch(true)` pattern with statements that evaluate to boolean as cases. (Feels like using guards in Haskell) - do not write PRs with excessively large changes as I did in this one, eventually I had to break it up to allow the reviewer to properly test everything since the changes are all across the codebase - naming is hard, naming branches with limited characters is harder ## [fix: shorthand notation o for the offline flag fixes #2400](https://github.com/netlify/cli/pull/2971) - sometimes it's not possible to just refactor a codebase to fix a bug the right way and you've to succumb to using a tempfix (which is very permanent) ## [refactor: enable and fix fp/no-proxy](https://github.com/netlify/cli/pull/2931) - the Proxy object in JS (I don't completely get this yet) - colorless instance in [chalk](https://github.com/chalk/chalk) (for logging to files?) ## [fix(docs-contributing): clarify our deploy tests create a live site](https://github.com/netlify/cli/pull/2895) - used the [chalk](https://github.com/chalk/chalk) package for styling text - came across [ci-info](https://github.com/watson/ci-info) - maintainers have other work too (I'm holding the urge to @ people constantly in my PRs) - decided to read up more about the [oclif](https://github.com/oclif/oclif) cli framework that the repo uses - `npm link` to use the repo cli directly (through symlinks) instead of doing a global install - I made an typo in this one and fixed it after a few months in [#3563](https://github.com/netlify/cli/pull/3563) ## [refactor: enable and fix fp/no-loops](https://github.com/netlify/cli/pull/2852) - for loops are easier to understand over using confusing recursive approaches or functional array methods (easy to realise but hard to accept as an FP fan) - used `Promise.all`, `Promise.allSettled`, `Promise.any` (N.B. Promise.allSetlled doesn't make the async call in order unlike a for loop) - installed and tried out `nvm` to debug an issue caused due to Node.js 10 not supporting the `?.` operator @@ -55,6 +64,7 @@ - `Object.entries(a).map([key, value]) => {})` is a pretty neat way to use key-value pairs from an object. ## [refactor: enable and fix class-methods-use-this](https://github.com/netlify/cli/pull/2827) - learnt more about static methods in JS classes (in most cases, separating these methods from classes is better) - came across the [ascii-table](https://www.npmjs.com/package/ascii-table) package, output data as tables easily on terminal ``` @@ -70,4 +80,4 @@ - pattern matching through `*` in npm scripts, useful for separation e.g. `test:dev:*` will run all scripts that start with the word `test:dev:` - came across git lfs (could use these for my figma design files) - using objects to pass arguments so when one is removed, you don't need to care about the positioning (not sure about using this for other langs but seems good for js due to the spread operator and object property shorthand) - the pain of flaky tests; can't debug code if it's not wrong -
tinfoil-knight revised this gist
Nov 3, 2021 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -3,7 +3,7 @@ ## [chore: replace deprecated querystring package with URLSearchParams API closes](https://github.com/netlify/cli/pull/3569) - be a bit more patient with what you claim, always double-check, mistakes will forever be out there in the public forum - there's a deprecated tag in JSDoc that can be used to mark things that are outdated - I tried to test my changes for this PR but gave up after some point and had to take things out and manually test them outside the repo, still not sure if everything is going to work, fortunately there are 3 folks tagged on this PR for review ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) - sometimes you can avoid using a mock by making a wrapper and only testing the responses from the core function's response instead of checking if the wrapping function throws an error, exits the process etc. -
tinfoil-knight revised this gist
Nov 3, 2021 . 1 changed file with 2 additions and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -2,7 +2,8 @@ ## [chore: replace deprecated querystring package with URLSearchParams API closes](https://github.com/netlify/cli/pull/3569) - be a bit more patient with what you claim, always double-check, mistakes will forever be out there in the public forum - there's a deprecated tag in JSDoc that can be used to mark things that are outdated - I tried to test my changes for this PR but gave up after some point and had to take things out and manually test them outside the repo ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) - sometimes you can avoid using a mock by making a wrapper and only testing the responses from the core function's response instead of checking if the wrapping function throws an error, exits the process etc. -
tinfoil-knight revised this gist
Nov 3, 2021 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -2,7 +2,7 @@ ## [chore: replace deprecated querystring package with URLSearchParams API closes](https://github.com/netlify/cli/pull/3569) - be a bit more patient with what you claim, always double-check, mistakes will forever be out there in the public forum - there's a deprecated tag in JSDoc that can be used to mark things that are outdated. ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) - sometimes you can avoid using a mock by making a wrapper and only testing the responses from the core function's response instead of checking if the wrapping function throws an error, exits the process etc. -
tinfoil-knight revised this gist
Nov 3, 2021 . 1 changed file with 2 additions and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,7 +1,8 @@ # OSS Log ## [chore: replace deprecated querystring package with URLSearchParams API closes](https://github.com/netlify/cli/pull/3569) - be a bit more patient with what you claim, always double-check, mistakes will forever be out there in the public forum - there's a deprecated tag in JSDoc that can be used ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) - sometimes you can avoid using a mock by making a wrapper and only testing the responses from the core function's response instead of checking if the wrapping function throws an error, exits the process etc. -
tinfoil-knight revised this gist
Nov 3, 2021 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,7 +1,7 @@ # OSS Log ## [chore: replace deprecated querystring package with URLSearchParams API closes](https://github.com/netlify/cli/pull/3569) - be a bit more patient with what you claim, always double-check, mistakes will forever be out there in the public forrum ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) - sometimes you can avoid using a mock by making a wrapper and only testing the responses from the core function's response instead of checking if the wrapping function throws an error, exits the process etc. -
tinfoil-knight revised this gist
Nov 3, 2021 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,7 +1,7 @@ # OSS Log ## [chore: replace deprecated querystring package with URLSearchParams API closes](https://github.com/netlify/cli/pull/3569) - be a bit more patient with what you claim, mistakes will forever be out there in the public forrum ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) - sometimes you can avoid using a mock by making a wrapper and only testing the responses from the core function's response instead of checking if the wrapping function throws an error, exits the process etc. -
tinfoil-knight revised this gist
Nov 3, 2021 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,7 +1,7 @@ # OSS Log ## [chore: replace deprecated querystring package with URLSearchParams API closes](https://github.com/netlify/cli/pull/3569) - be a bit more patient with what you declare, mistakes will forever be out there in the public forrum ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) - sometimes you can avoid using a mock by making a wrapper and only testing the responses from the core function's response instead of checking if the wrapping function throws an error, exits the process etc. -
tinfoil-knight revised this gist
Nov 3, 2021 . 1 changed file with 3 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,5 +1,8 @@ # OSS Log ## [chore: replace deprecated querystring package with URLSearchParams API closes](https://github.com/netlify/cli/pull/3569) - be a bit more patient with what you declare, things in public forums can't be taken back ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) - sometimes you can avoid using a mock by making a wrapper and only testing the responses from the core function's response instead of checking if the wrapping function throws an error, exits the process etc. -
tinfoil-knight revised this gist
Sep 26, 2021 . 1 changed file with 3 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,5 +1,8 @@ # OSS Log ## [refactor: split core function of getAgent for better testing](https://github.com/netlify/cli/pull/3392) - sometimes you can avoid using a mock by making a wrapper and only testing the responses from the core function's response instead of checking if the wrapping function throws an error, exits the process etc. ## [refactor: remove unused function detectAwsSdkError](https://github.com/netlify/cli/pull/3383) - don't just remove dead code without asking the original author - don't club changes you find while working on a PR, always create a separate PR for unrelated changes -
tinfoil-knight revised this gist
Sep 22, 2021 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,6 +1,6 @@ # OSS Log ## [refactor: remove unused function detectAwsSdkError](https://github.com/netlify/cli/pull/3383) - don't just remove dead code without asking the original author - don't club changes you find while working on a PR, always create a separate PR for unrelated changes -
tinfoil-knight revised this gist
Sep 22, 2021 . 1 changed file with 4 additions and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,5 +1,8 @@ # OSS Log ## [](https://github.com/netlify/cli/pull/3383) - don't just remove dead code without asking the original author - don't club changes you find while working on a PR, always create a separate PR for unrelated changes ## [refactor: warn, exit and error utils from oclif command class](https://github.com/netlify/cli/pull/3028) - `switch(true)` pattern with statements that evaluate to boolean as cases. (Feels like using guards in Haskell) -
tinfoil-knight revised this gist
Sep 21, 2021 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -4,7 +4,7 @@ Mostly learning. Some rants and opinions too. ## [refactor: warn, exit and error utils from oclif command class](https://github.com/netlify/cli/pull/3028) - `switch(true)` pattern with statements that evaluate to boolean as cases. (Feels like using guards in Haskell) - do not write PRs with excessively large changes as I did in this one, eventually I had to break it up to allow the reviewer to properly test everything since the changes are all across the codebase - naming is hard, naming branches with limited characters is harder ## [fix: shorthand notation o for the offline flag fixes #2400](https://github.com/netlify/cli/pull/2971) - sometimes it's not possible to just refactor a codebase to fix a bug the right way and you've to succumb to using a tempfix (which is very permanent) -
tinfoil-knight revised this gist
Sep 21, 2021 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -4,7 +4,7 @@ Mostly learning. Some rants and opinions too. ## [refactor: warn, exit and error utils from oclif command class](https://github.com/netlify/cli/pull/3028) - `switch(true)` pattern with statements that evaluate to boolean as cases. (Feels like using guards in Haskell) - do not write PRs with excessively large changes as I did in this one, eventually I had to break it up to allow the reviewer to properly test everything since the changes are all across the codebase - naming is hard, naming branches with limited characters is even harder ## [fix: shorthand notation o for the offline flag fixes #2400](https://github.com/netlify/cli/pull/2971) - sometimes it's not possible to just refactor a codebase to fix a bug the right way and you've to succumb to using a tempfix (which is very permanent) -
tinfoil-knight revised this gist
Sep 21, 2021 . 1 changed file with 2 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -3,6 +3,8 @@ Mostly learning. Some rants and opinions too. ## [refactor: warn, exit and error utils from oclif command class](https://github.com/netlify/cli/pull/3028) - `switch(true)` pattern with statements that evaluate to boolean as cases. (Feels like using guards in Haskell) - do not write PRs with excessively large changes as I did in this one, eventually I had to break it up to allow the reviewer to properly test everything since the changes are all across the codebase - naming is hard, naming branches with limited characters is even hard ## [fix: shorthand notation o for the offline flag fixes #2400](https://github.com/netlify/cli/pull/2971) - sometimes it's not possible to just refactor a codebase to fix a bug the right way and you've to succumb to using a tempfix (which is very permanent) -
tinfoil-knight revised this gist
Jul 28, 2021 . 1 changed file with 3 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,6 +1,9 @@ # OSS Log Mostly learning. Some rants and opinions too. ## [refactor: warn, exit and error utils from oclif command class](https://github.com/netlify/cli/pull/3028) - `switch(true)` pattern with statements that evaluate to boolean as cases. (Feels like using guards in Haskell) ## [fix: shorthand notation o for the offline flag fixes #2400](https://github.com/netlify/cli/pull/2971) - sometimes it's not possible to just refactor a codebase to fix a bug the right way and you've to succumb to using a tempfix (which is very permanent) -
tinfoil-knight revised this gist
Jul 22, 2021 . 1 changed file with 7 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,6 +1,13 @@ # OSS Log Mostly learning. Some rants and opinions too. ## [fix: shorthand notation o for the offline flag fixes #2400](https://github.com/netlify/cli/pull/2971) - sometimes it's not possible to just refactor a codebase to fix a bug the right way and you've to succumb to using a tempfix (which is very permanent) ## [refactor: enable and fix fp/no-proxy](https://github.com/netlify/cli/pull/2931) - the Proxy object in JS (I don't completely get this yet) - colorless instance in [chalk](https://github.com/chalk/chalk) (for logging to files?) ## [fix(docs-contributing): clarify our deploy tests create a live site](https://github.com/netlify/cli/pull/2895) - used the [chalk](https://github.com/chalk/chalk) package for styling text - came across [ci-info](https://github.com/watson/ci-info)
NewerOlder