Skip to content

Instantly share code, notes, and snippets.

View vikas-srivastava's full-sized avatar

Vikas Srivastava vikas-srivastava

View GitHub Profile
@vikas-srivastava
vikas-srivastava / codereview.md
Created April 24, 2025 18:40 — forked from addyosmani/codereview.md
Lessons from a JavaScript code review

#Lessons From A JavaScript Code Review

I was recently asked to review some code for a new JavaScript application and thought I might share some of the feedback I provided as it includes a mention of JavaScript fundamentals that are always useful to bear in mind. Code reviews are possibly the single biggest thing you can do to improve the overall quality of your solutions and if you're not actively taking advantage of them, you're possibly missing out on bugs you haven't noticed being found or suggestions for improvements that could make your code better.

##Challenges & Solutions

Code reviews go hand-in-hand with maintaining strong coding standards. That said, standards don't usually prevent logical errors or misunderstandings about the quirks of a programming language. Even the most experienced developers can make these kinds of mistakes and code reviews can greatly assist with catching them.

Often the most challenging part of code reviews is actually finding an experienced developer you trust to complete

@vikas-srivastava
vikas-srivastava / python-guide-ist.md
Created April 24, 2025 18:35 — forked from ruimaranhao/python-guide-ist.md
A guide of best practices to developing in Python (meant for the first year students of the Instituto Superior Técnico, U.Lisboa).

A Guide of Best Practices for Python

A guide of best practices to developing in Python (meant for the first year students of the Instituto Superior Técnico, University of Lisbon). Do you want to have a hard-cover book on this, check this list out.

Inspired in Steve Sloria's gist.

In General

"Beautiful is better than ugly." - [PEP 20][]

@vikas-srivastava
vikas-srivastava / kind-code-review.md
Created April 24, 2025 18:31 — forked from ross-spencer/kind-code-review.md
Code Review (CR) Guidelines and Principles
Status: Work in progress
Use: Unofficial
Language: Python

Kind code review

Summary

@vikas-srivastava
vikas-srivastava / code-review-checklist.md
Created October 23, 2021 12:35 — forked from nerandell/code-review-checklist.md
PHP Code Review Guidelines

Make sure these boxes are checked before submitting/approving the PR

General

  • The code works
  • The code is easy to understand
  • Follows coding conventions
  • Names are simple and if possible short
  • Names are spelt correctly
  • Names contain units where applicable
  • There are no usages of magic numbers