-
-
Save vikas-srivastava/d2ce4a1a8aaa729f6870afb9b258c95e to your computer and use it in GitHub Desktop.
Revisions
-
ruimaranhao revised this gist
Nov 28, 2018 . 1 changed file with 1 addition and 12 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -65,6 +65,7 @@ controller = audio.Controller() **No** ```python import audio from audio import * core = audio.AudioCore() controller = audio.AudioController() @@ -86,18 +87,6 @@ active_elements = ... defunct_elements ... ``` #### Indentation Up to you, but be consistent. [Enough said](https://thenewstack.io/spaces-vs-tabs-a-20-year-debate-and-now-this-what-the-hell-is-wrong-with-go/). -
ruimaranhao revised this gist
Nov 25, 2018 . 1 changed file with 10 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -161,6 +161,16 @@ for i in a: b.append(i) ``` #### Keyword `with` and files The `with` statement ensures that clean-up code is executed. When opening a file, `with` will make sure that the file is closed after the `with` block. **Yes** ```python with open('file.txt') as f: do_something_with_f ``` #### Imports Import entire modules instead of individual symbols within a module. For example, for a top-level module `canteen` that has a file `canteen/sessions.py`, -
ruimaranhao revised this gist
Nov 25, 2018 . 1 changed file with 7 additions and 7 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -113,29 +113,29 @@ Avoid comparing to `True`, `False` or `None`. **Yes** ```python if attr: print('True!') if attr is True: print('True!') if not attr: print('False!') if attr is None: print('None') ``` **No** ```python if attr == True: print('True!') if attr == False: print('False!') if attr == None: print('None') ``` #### List comprehensions -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -118,7 +118,7 @@ if attr: if attr is True: print 'True!' if not attr: print 'False!' if attr is None: -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -340,9 +340,9 @@ Notice how the testcase and test method read together like "Test A User can writ ## Inspired by... - :bookmark_tabs: [The Hitchiker's Guide to Python][python-guide] :warning: - [PEP 20 (The Zen of Python)][PEP 20] - [PEP 8 (Style Guide for Python)][PEP 8] - [Khan Academy Development Docs][] - [Python Best Practice Patterns][] - [Pythonic Sensibilities][] -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 1 addition and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -147,6 +147,7 @@ Use list comprehension when possible. a = [3, 4, 5] b = [i for i in a if i > 4] #Or (filter is this case; map could also be more appropriate in other cases) b = filter(lambda x: x > 4, a) ``` -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 53 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -106,6 +106,59 @@ Up to you, but be consistent. [Enough said](https://thenewstack.io/spaces-vs-tab However, note that: A tab could be a different number of columns depending on your environment, but a space is always one column. In terms of how many spaces (or tabs) constitutes indentation, it's more important to be consistent throughout your code than to use any specific tab stop value. #### Equality checking Avoid comparing to `True`, `False` or `None`. **Yes** ```python if attr: print 'True!' if attr is True: print 'True!' if !attr: print 'False!' if attr is None: print 'None' ``` **No** ```python if attr == True: print 'True!' if attr == False: print 'False!' if attr == None: print 'None' ``` #### List comprehensions Use list comprehension when possible. **Yes** ```python a = [3, 4, 5] b = [i for i in a if i > 4] b = filter(lambda x: x > 4, a) ``` **No** ```python a = [3, 4, 5] b = [] for i in a: if i > 4: b.append(i) ``` #### Imports -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 3 additions and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -225,6 +225,8 @@ wiki = ( ) ``` <details><summary>Advanced Material</summary> ### Advanced Material: Testing Strive for 100% code coverage, but don't get obsess over the coverage score. @@ -280,7 +282,7 @@ class TestAUser(unittest.TestCase): ``` Notice how the testcase and test method read together like "Test A User can write a blog post". </details> ## Inspired by... -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -225,7 +225,7 @@ wiki = ( ) ``` ### Advanced Material: Testing Strive for 100% code coverage, but don't get obsess over the coverage score. -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,7 +1,7 @@ # A Guide of Best Practices for Python A guide of best practices to developing in Python (meant for the first year students of the [Instituto Superior Técnico](https://www.tecnico.ulisboa.pt/), [University of Lisbon](https://www.ulisboa.pt/pt/)). Do you want to have a hard-cover book on this, check this [list](https://hub.packtpub.com/top-7-python-programming-books-need-to-read/) out. Inspired in Steve Sloria's [gist](https://gist.github.com/sloria/7001839). -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 1 addition and 3 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -1,12 +1,10 @@ # A Guide of Best Practices for Python A guide of best practices to developing in Python (meant for the first year students of the [Instituto Superior Técnico](https://www.tecnico.ulisboa.pt/), [University of Lisbon](https://www.ulisboa.pt/pt/). Do you want to have a hard-cover book on this, check this [list](https://hub.packtpub.com/top-7-python-programming-books-need-to-read/) out. Inspired in Steve Sloria's [gist](https://gist.github.com/sloria/7001839). ## In General > "Beautiful is better than ugly." - [PEP 20][] -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 2 additions and 0 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -5,6 +5,8 @@ A guide of best practices to developing in Python (meant for the first year stud Inspired in Steve Sloria's [gist](https://gist.github.com/sloria/7001839). Do you want to have a hard-cover book on this, check this [list](https://hub.packtpub.com/top-7-python-programming-books-need-to-read/) out. ## In General > "Beautiful is better than ugly." - [PEP 20][] -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 2 additions and 2 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -128,7 +128,7 @@ from canteen.sessions import get_session # Symbol from canteen/sessions.py *Exception*: For third-party code where documentation explicitly says to import individual symbols. *Rationale*: Avoids circular imports. See [here](https://stackabuse.com/python-circular-imports/). Put all imports at the top of the page with three sections, each separated by a blank line, in this order: @@ -142,7 +142,7 @@ Put all imports at the top of the page with three sections, each separated by a Follow [PEP 257][]'s docstring guidelines. [reStructured Text](http://docutils.sourceforge.net/docs/user/rst/quickref.html) and [Sphinx](http://sphinx-doc.org/) can help to enforce these standards. When possible, use one-line docstrings for obvious functions. ```python """Return the pathname of ``foo``.""" -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 1 addition and 3 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -104,9 +104,7 @@ Up to you, but be consistent. [Enough said](https://thenewstack.io/spaces-vs-tab  However, note that: A tab could be a different number of columns depending on your environment, but a space is always one column. In terms of how many spaces (or tabs) constitutes indentation, it's more important to be consistent throughout your code than to use any specific tab stop value. #### Imports -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 8 additions and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -100,7 +100,14 @@ person.set_age(42) #### Indentation Up to you, but be consistent. [Enough said](https://thenewstack.io/spaces-vs-tabs-a-20-year-debate-and-now-this-what-the-hell-is-wrong-with-go/).  However, note that: A tab could be a different number of columns depending on your environment, but a space is always one column. In terms of how many spaces (or tabs) constitutes indentation, it's more important to be consistent throughout your code than to use any specific tab stop value. #### Imports -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -100,7 +100,7 @@ person.set_age(42) #### Indentation Use 4 spaces--never tabs. [Enough said](https://thenewstack.io/spaces-vs-tabs-a-20-year-debate-and-now-this-what-the-hell-is-wrong-with-go/). #### Imports -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 1 addition and 1 deletion.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -15,7 +15,7 @@ Inspired in Steve Sloria's [gist](https://gist.github.com/sloria/7001839). - "Explicit is better than implicit" - [PEP 20][] - "Readability counts." - [PEP 20][] - "Anybody can fix anything." - [Khan Academy Development Docs][] - Fix each issue (bad design, wrong decision, or poor code) *as soon as it is discovered*. - "Now is better than never." - [PEP 20][] - Test ruthlessly. Write docs for new features. - Even more important that Test-Driven Development--*Human-Driven Development* -
ruimaranhao revised this gist
Nov 22, 2018 . 1 changed file with 2 additions and 7 deletions.There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -3,17 +3,12 @@ A guide of best practices to developing in Python (meant for the first year students of the [Instituto Superior Técnico](https://www.tecnico.ulisboa.pt/), [University of Lisbon](https://www.ulisboa.pt/pt/). Inspired in Steve Sloria's [gist](https://gist.github.com/sloria/7001839). ## In General > "Beautiful is better than ugly." - [PEP 20][] ### General Development Guidelines -
ruimaranhao renamed this gist
Nov 22, 2018 . 1 changed file with 0 additions and 0 deletions.There are no files selected for viewing
File renamed without changes. -
ruimaranhao created this gist
Nov 22, 2018 .There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode charactersOriginal file line number Diff line number Diff line change @@ -0,0 +1,303 @@ # A Guide of Best Practices for Python A guide of best practices to developing in Python (meant for the first year students of the [Instituto Superior Técnico](https://www.tecnico.ulisboa.pt/), [University of Lisbon](https://www.ulisboa.pt/pt/). Inpirired in Steve Sloria's [gist](https://gist.github.com/sloria/7001839). ## In General ### Values - "Build tools for others that you want to be built for you." - Kenneth Reitz - "Simplicity is alway better than functionality." - Pieter Hintjens - "Fit the 90% use-case. Ignore the nay sayers." - Kenneth Reitz - "Beautiful is better than ugly." - [PEP 20][] - Build for open source (even for closed source projects). ### General Development Guidelines - "Explicit is better than implicit" - [PEP 20][] - "Readability counts." - [PEP 20][] - "Anybody can fix anything." - [Khan Academy Development Docs][] - Fix each [broken window](http://www.artima.com/intv/fixit2.html) (bad design, wrong decision, or poor code) *as soon as it is discovered*. - "Now is better than never." - [PEP 20][] - Test ruthlessly. Write docs for new features. - Even more important that Test-Driven Development--*Human-Driven Development* - These guidelines may--and probably will--change. ## In Particular ### Style Follow [PEP 8][], when sensible. #### Naming - Variables, functions, methods, packages, modules - `lower_case_with_underscores` - Classes and Exceptions - `CapWords` - Protected methods and internal functions - `_single_leading_underscore(self, ...)` - Private methods - `__double_leading_underscore(self, ...)` - Constants - `ALL_CAPS_WITH_UNDERSCORES` ###### General Naming Guidelines Avoid one-letter variables (esp. `l`, `O`, `I`). *Exception*: In very short blocks, when the meaning is clearly visible from the immediate context **Fine** ```python for e in elements: e.mutate() ``` Avoid redundant labeling. **Yes** ```python import audio core = audio.Core() controller = audio.Controller() ``` **No** ```python import audio core = audio.AudioCore() controller = audio.AudioController() ``` Prefer "reverse notation". **Yes** ```python elements = ... elements_active = ... elements_defunct = ... ``` **No** ```python elements = ... active_elements = ... defunct_elements ... ``` Avoid getter and setter methods. **Yes** ```python person.age = 42 ``` **No** ```python person.set_age(42) ``` #### Indentation Use 4 spaces--never tabs. Enough said. #### Imports Import entire modules instead of individual symbols within a module. For example, for a top-level module `canteen` that has a file `canteen/sessions.py`, **Yes** ```python import canteen import canteen.sessions from canteen import sessions ``` **No** ```python from canteen import get_user # Symbol from canteen/__init__.py from canteen.sessions import get_session # Symbol from canteen/sessions.py ``` *Exception*: For third-party code where documentation explicitly says to import individual symbols. *Rationale*: Avoids circular imports. See [here](https://sites.google.com/a/khanacademy.org/forge/for-developers/styleguide/python#TOC-Imports). Put all imports at the top of the page with three sections, each separated by a blank line, in this order: 1. System imports 2. Third-party imports 3. Local source tree imports *Rationale*: Makes it clear where each module is coming from. #### Documentation Follow [PEP 257][]'s docstring guidelines. [reStructured Text](http://docutils.sourceforge.net/docs/user/rst/quickref.html) and [Sphinx](http://sphinx-doc.org/) can help to enforce these standards. Use one-line docstrings for obvious functions. ```python """Return the pathname of ``foo``.""" ``` Multiline docstrings should include - Summary line - Use case, if appropriate - Args - Return type and semantics, unless ``None`` is returned ```python """Train a model to classify Foos and Bars. Usage:: >>> import klassify >>> data = [("green", "foo"), ("orange", "bar")] >>> classifier = klassify.train(data) :param train_data: A list of tuples of the form ``(color, label)``. :rtype: A :class:`Classifier <Classifier>` """ ``` Notes - Use action words ("Return") rather than descriptions ("Returns"). - Document `__init__` methods in the docstring for the class. ```python class Person(object): """A simple representation of a human being. :param name: A string, the person's name. :param age: An int, the person's age. """ def __init__(self, name, age): self.name = name self.age = age ``` ##### On comments Use them sparingly. Prefer code readability to writing a lot of comments. Often, small methods are more effective than comments. *No* ```python # If the sign is a stop sign if sign.color == 'red' and sign.sides == 8: stop() ``` *Yes* ```python def is_stop_sign(sign): return sign.color == 'red' and sign.sides == 8 if is_stop_sign(sign): stop() ``` When you do write comments, remember: "Strunk and White apply." - [PEP 8][] #### Line lengths Don't stress over it. 80-100 characters is fine. Use parentheses for line continuations. ```python wiki = ( "The Colt Python is a .357 Magnum caliber revolver formerly manufactured " "by Colt's Manufacturing Company of Hartford, Connecticut. It is sometimes " 'referred to as a "Combat Magnum". It was first introduced in 1955, the ' "same year as Smith & Wesson's M29 .44 Magnum." ) ``` ### Testing Strive for 100% code coverage, but don't get obsess over the coverage score. #### General testing guidelines - Use long, descriptive names. This often obviates the need for doctrings in test methods. - Tests should be isolated. Don't interact with a real database or network. Use a separate test database that gets torn down or use mock objects. - Prefer [factories](https://github.com/rbarrois/factory_boy) to fixtures. - Never let incomplete tests pass, else you run the risk of forgetting about them. Instead, add a placeholder like `assert False, "TODO: finish me"`. #### Unit Tests - Focus on one tiny bit of functionality. - Should be fast, but a slow test is better than no test. - It often makes sense to have one testcase class for a single class or model. ```python import unittest import factories class PersonTest(unittest.TestCase): def setUp(self): self.person = factories.PersonFactory() def test_has_age_in_dog_years(self): self.assertEqual(self.person.dog_years, self.person.age / 7) ``` #### Functional Tests Functional tests are higher level tests that are closer to how an end-user would interact with your application. They are typically used for web and GUI applications. - Write tests as scenarios. Testcase and test method names should read like a scenario description. - Use comments to write out stories, *before writing the test code*. ```python import unittest class TestAUser(unittest.TestCase): def test_can_write_a_blog_post(self): # Goes to the her dashboard ... # Clicks "New Post" ... # Fills out the post form ... # Clicks "Submit" ... # Can see the new post ... ``` Notice how the testcase and test method read together like "Test A User can write a blog post". ## Inspired by... - [PEP 20 (The Zen of Python)][PEP 20] - [PEP 8 (Style Guide for Python)][PEP 8] - [The Hitchiker's Guide to Python][python-guide] - [Khan Academy Development Docs][] - [Python Best Practice Patterns][] - [Pythonic Sensibilities][] - [The Pragmatic Programmer][] - and many other bits and bytes [Pythonic Sensibilities]: http://www.nilunder.com/blog/2013/08/03/pythonic-sensibilities/ [Python Best Practice Patterns]: http://youtu.be/GZNUfkVIHAY [python-guide]: http://docs.python-guide.org/en/latest/ [PEP 20]: http://www.python.org/dev/peps/pep-0020/ [PEP 257]: http://www.python.org/dev/peps/pep-0257/ [PEP 8]: http://www.python.org/dev/peps/pep-0008/ [Khan Academy Development Docs]: https://sites.google.com/a/khanacademy.org/forge/for-developers [The Pragmatic Programmer]: http://www.amazon.com/The-Pragmatic-Programmer-Journeyman-Master/dp/020161622X/ref=sr_1_1?ie=UTF8&qid=1381886835&sr=8-1&keywords=pragmatic+programmer